Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The schema uses `additionalProperties: false` while also referencing `common.yaml#`, which will incorrectly reject standard inherited properties. --
--- Patch [1]: [PATCH v2 1/2] dt-bindings: backlight: Add Orient Chip OCP8178 --- commit e31a9b24875ae6868d7bab27e5c73b0f9db06347 Author: Wim de With <[email protected]> dt-bindings: backlight: Add Orient Chip OCP8178 This commit adds device tree bindings for the Orient Chip OCP8178 LED backlight driver, introducing a new YAML schema. > diff --git > a/Documentation/devicetree/bindings/leds/backlight/ocs,ocp8178.yaml > b/Documentation/devicetree/bindings/leds/backlight/ocs,ocp8178.yaml > new file mode 100644 > index 0000000000000..57c44d3383b88 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/ocs,ocp8178.yaml [ ... ] > +allOf: > + - $ref: common.yaml# > + > +properties: [ ... ] > +required: > + - compatible > + - enable-gpios > + > +additionalProperties: false [Severity: Medium] Since this schema references common.yaml, should this be set to unevaluatedProperties: false instead? Using additionalProperties: false will incorrectly reject legitimate properties inherited from common.yaml during schema validation. > + > +examples: [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
