Series still has my RB. Alex
On Mon, Aug 10, 2026 at 8:03 AM Pierre-Eric Pelloux-Prayer <[email protected]> wrote: > > amdgpu_ttm_disable_buffer_funcs and amdgpu_ttm_enable_buffer_funcs should > each only be called once per amdgpu_device: at startup and teardown. > > Therefore the other calls are redundant and can be safely dropped. > > Signed-off-by: Pierre-Eric Pelloux-Prayer <[email protected]> > Reviewed-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ----- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 - > 2 files changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 1ec3162cb175..e966e6f7d2fa 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -3379,8 +3379,6 @@ static int amdgpu_device_ip_resume(struct amdgpu_device > *adev) > > r = amdgpu_device_ip_resume_phase2(adev); > > - amdgpu_ttm_enable_buffer_funcs(adev); > - > if (r) > return r; > > @@ -4511,8 +4509,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool > notify_clients) > if (r) > goto unwind_userq; > > - amdgpu_ttm_disable_buffer_funcs(adev); > - > amdgpu_fence_driver_hw_fini(adev); > > r = amdgpu_device_ip_suspend_phase2(adev); > @@ -4525,7 +4521,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool > notify_clients) > return 0; > > unwind_evict: > - amdgpu_ttm_enable_buffer_funcs(adev); > amdgpu_fence_driver_hw_init(adev); > > unwind_userq: > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index 5bcb6a966941..ba99edbfe3a6 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -2137,7 +2137,6 @@ int amdgpu_ttm_init(struct amdgpu_device *adev) > } > > /* Change the size here instead of the init above so only lpfn is > affected */ > - amdgpu_ttm_disable_buffer_funcs(adev); > #ifdef CONFIG_64BIT > #ifdef CONFIG_X86 > if (adev->gmc.xgmi.connected_to_cpu) > -- > 2.43.0 >
