On 8/12/26 10:50 PM, Vladislav Zaharov wrote: > On Thu Aug 13, 2026, Danilo Krummrich wrote: >> I'd *much* rather use a kernel parameter: keep_gsp_logs, instead of >> requiring a rebuild of the kernel. > > Agreed, and it makes the patch smaller: with a module parameter the cfg gating > disappears and the code is simply always built. I used a Kconfig because of > the > "the only Kconfig needed is for retaining the GSP log buffers after driver > unbind" remark in the earlier thread, which I took literally instead of > asking. > > That one needs a decision, though. The Rust module parameter abstraction has > no > bool: rust/kernel/module_param.rs only instantiates param ops for i8..u64,
Yes, this seems perfectly acceptable, given that we don't have bool support yet: keep_gsp_logs=[0|1] thanks, -- John Hubbard
