Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `reset_plane` function pointer remains in `struct drm_simple_display_pipe_funcs` despite the commit explicitly removing all core support for it. --
--- Patch [7]: [PATCH v2 07/61] drm/simple-kms: Switch to atomic_create_state --- commit 40c453e97222f62dc64493eb74e4a3f1f2594633 Author: Maxime Ripard <[email protected]> drm/simple-kms: Switch to atomic_create_state This commit replaces drm_simple_kms_plane_reset() with drm_simple_kms_plane_create_state(). It simplifies the initialization by dispatching only to the new create_plane_state hook and removing support for the old reset_plane hook. > diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c > b/drivers/gpu/drm/drm_simple_kms_helper.c > index 528968ea5c4be..c99ff74dca922 100644 > --- a/drivers/gpu/drm/drm_simple_kms_helper.c > +++ b/drivers/gpu/drm/drm_simple_kms_helper.c [ ... ] > - if (pipe->funcs->reset_plane) > - return pipe->funcs->reset_plane(pipe); > + if (!pipe->funcs || !pipe->funcs->create_plane_state) > + return drm_atomic_helper_plane_create_state(plane); [Severity: Low] Since support for the reset_plane callback is removed here, should the reset_plane function pointer also be removed from struct drm_simple_display_pipe_funcs in include/drm/drm_simple_kms_helper.h? Leaving it in the struct means out-of-tree drivers might still compile without warnings if they implement a reset_plane callback, but their custom logic will be silently ignored at runtime. > - return drm_atomic_helper_plane_reset(plane); > + return pipe->funcs->create_plane_state(pipe); > } -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
