On 11/08/2026 12:23, Boris Brezillon wrote: > This lock is never used, and we're about to make fatal_queues an > atomic to cope with concurrent updates. > > Signed-off-by: Boris Brezillon <[email protected]>
Reviewed-by: Steven Price <[email protected]> Although it does make me wonder if there's a fix that needs backporting... Thanks, Steve > --- > drivers/gpu/drm/panthor/panthor_sched.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c > b/drivers/gpu/drm/panthor/panthor_sched.c > index baa06731797c..9adf1e21eb83 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -565,9 +565,6 @@ struct panthor_group { > /** @idle_queues: Bitmask reflecting the idle queues. */ > u32 idle_queues; > > - /** @fatal_lock: Lock used to protect access to fatal fields. */ > - spinlock_t fatal_lock; > - > /** @fatal_queues: Bitmask reflecting the queues that hit a fatal > exception. */ > u32 fatal_queues; > > @@ -3675,7 +3672,6 @@ int panthor_group_create(struct panthor_file *pfile, > if (!group) > return -ENOMEM; > > - spin_lock_init(&group->fatal_lock); > kref_init(&group->refcount); > group->state = PANTHOR_CS_GROUP_CREATED; > group->csg_id = -1; >
