Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Violation of vertical import style by adding a separate import statement instead of grouping with existing imports. --
--- Patch [8]: [PATCH v3 08/16] drm/tyr: specify base type for registers --- commit 34aca3035b4614556abef99eebb9d34305820b18 Author: Gary Guo <[email protected]> drm/tyr: specify base type for registers This commit specifies the base parameter for the register definitions in the drm/tyr driver. It introduces and utilizes TyrRegisters to standardize the base type across the register! macro invocations. > diff --git a/drivers/gpu/drm/tyr/regs.rs b/drivers/gpu/drm/tyr/regs.rs > index a62724378ced2..0c419c4e1186c 100644 > --- a/drivers/gpu/drm/tyr/regs.rs > +++ b/drivers/gpu/drm/tyr/regs.rs > @@ -57,7 +57,11 @@ pub(crate) mod gpu_control { > uapi, // > }; > > + use crate::driver::TyrRegisters; [Severity: Low] This isn't a bug, but should this import be grouped with the existing crate::driver imports above to follow the kernel's vertical import style guidelines? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8
