Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The binding incorrectly uses `additionalProperties: false` alongside an `allOf` `$ref` to `panel-common.yaml`, preventing the use of standard panel properties. --
--- Patch [1]: [PATCH v2 1/3] dt-bindings: display: add Chipwealth CH1115 OLED Controller --- commit dea96c423e55cd876a4ae165ef9b13a3b42cc6fc Author: Nicolás Antinori <[email protected]> dt-bindings: display: add Chipwealth CH1115 OLED Controller Chipwealth CH1115 is a controller for monochrome dot matrix OLED panels. > diff --git a/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml > b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml > new file mode 100644 > index 0000000000000..9d9c437221312 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml [ ... ] > +allOf: > + - $ref: panel/panel-common.yaml# > + > +properties: [ ... ] > + chipwealth,contrast: > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 255 > + description: > + Panel contrast. > + > + width-mm: true > + height-mm: true > + flip-horizontal: true > + flip-vertical: true > + panel-timing: true [Severity: Low] Are these manual redefinitions of standard panel properties necessary? Since they are already included via panel-common.yaml above, redefining them locally appears to be a workaround for the additionalProperties: false schema evaluation issue noted below. > + > +required: > + - compatible > + - reg > + - width-mm > + - height-mm > + - panel-timing > + > +additionalProperties: false [Severity: Low] Should this use unevaluatedProperties: false instead? Using additionalProperties: false alongside an allOf $ref restricts the schema to evaluate only locally defined properties. This causes it to incorrectly reject standard properties included from panel-common.yaml, such as backlight, power-supply, or port. Changing this to unevaluatedProperties: false allows standard panel properties to be evaluated correctly, which also removes the need to manually redefine them in this file. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
