On Fri, Aug 21, 2026 at 04:39:30PM +0200, Maxime Ripard wrote: > The dpu1 crtc implementation provides a custom reset hook. However, > this hook only allocates the state, initializes it with > __drm_atomic_helper_crtc_reset(), and frees the previous state. It > does not perform any hardware reset. > > Since this is exactly what the atomic_create_state hook is meant to > do, minus the old state cleanup which the caller handles, convert the > implementation to use atomic_create_state with > __drm_atomic_helper_crtc_state_init() instead. > > Signed-off-by: Maxime Ripard <[email protected]> > --- > Cc: Abhinav Kumar <[email protected]> > Cc: Dmitry Baryshkov <[email protected]> > Cc: Jessica Zhang <[email protected]> > Cc: Marijn Suijten <[email protected]> > Cc: Rob Clark <[email protected]> > Cc: Sean Paul <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >
Reviewed-by: Dmitry Baryshkov <[email protected]> -- With best wishes Dmitry
