Hi Krzysztof, On Mon, 24 Aug 2026 at 14:17, Krzysztof Kozlowski <[email protected]> wrote: > > On 18/08/2026 12:40, Konrad Dybcio wrote: > > On 8/8/26 3:16 PM, Guangshuo Li wrote: > >> adreno_gpu_init() calls pm_runtime_use_autosuspend(), but > >> adreno_gpu_cleanup() does not call the matching > >> pm_runtime_dont_use_autosuspend() during teardown. > >> > >> If the autosuspend delay is set to a negative value while autosuspend > >> is enabled, the runtime PM core increments usage_count to prevent > >> runtime suspend. Without calling pm_runtime_dont_use_autosuspend() > >> during teardown, this reference is not dropped and usage_count remains > >> unbalanced. > >> > >> The documentation for pm_runtime_use_autosuspend() also notes that it > >> is important to undo it with pm_runtime_dont_use_autosuspend() at > >> driver exit time, unless runtime PM was initially enabled with > >> devm_pm_runtime_enable(). > >> > >> Add the missing pm_runtime_dont_use_autosuspend() call to > >> adreno_gpu_cleanup(). > >> > >> This issue was found by manual code inspection. > >> > >> Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime") > >> Cc: [email protected] > >> Signed-off-by: Guangshuo Li <[email protected]> > >> --- > > > > I think we can use devm_pm_runtime_enable() instead, which will take > > care of cleaning up both the autosuspend and runpm halves > > > > Author here is unresponsive, he was told a few times to send corrections > for his vast amount of unthreaded patches and there is zero reaction. > > Best regards, > Krzysztof
Sorry about that. I should have replied to the earlier review comments explicitly, and I also should not have sent so many separate patches. I will group future patches by subsystem and make sure to respond clearly to review feedback before resending. Thanks for pointing this out. Best regards, Guangshuo
