Hi Krzysztof,

...

> @@ -400,11 +400,10 @@ static int intel_mmio_bases_check(void *arg)
>                       u32 base = info->mmio_bases[j].base;
>  
>                       if (ver >= prev) {
> -                             pr_err("%s(%s, class:%d, instance:%d): mmio 
> base for graphics ver %u is before the one for ver %u\n",
> -                                    __func__,
> -                                    intel_engine_class_repr(info->class),
> -                                    info->class, info->instance,
> -                                    prev, ver);
> +                             drm_err(NULL,
> +                                     "%s(%s, class:%d, instance:%d): mmio 
> base for graphics ver %u is before the one for ver %u\n",
> +                                     __func__, 
> intel_engine_class_repr(info->class),
> +                                     info->class, info->instance, prev, ver);

yah! drm_err(NULL, ...) is quite pointless. If there is no way
for retrieving the drm device, then let's just stick to pr_*,
this is their role.

Thanks,
Andi

>                               return -EINVAL;
>                       }

Reply via email to