Re: [PATCH v2 7/8] drm/i915/gt/selftests: Use drm_* prints in gt selftest helpers

[Andi Shyti]

Hi Krzysztof,

...

> diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c 
> b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> index b893a8fde895..6f5962eaca3b 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> @@ -202,8 +202,10 @@ static int __live_heartbeat_off(struct intel_engine_cs 
> *engine)
>       engine->serial++;
>       flush_delayed_work(&engine->heartbeat.work);
>       if (!delayed_work_pending(&engine->heartbeat.work)) {
> -             pr_err("%s: heartbeat not running\n",
> -                    engine->name);
> +             struct drm_printer m = drm_err_printer(&engine->i915->drm, 
> "heartbeat off");
> +
> +             drm_printf(&m, "%s: heartbeat not running\n", engine->name);
> +

I don't get this change, why don't you just use drm_err()?

Thanks,
Andi

>               err = -EINVAL;
>               goto err_pm;