Hi Krzysztof, On 2026-08-28 at 10:03:37 +0000, Krzysztof Karas wrote: > Move away from generic pr prints to device context aware drm > versions. > > Assisted-by: GitHub-Copilot:claude-opus-5 > Signed-off-by: Krzysztof Karas <[email protected]> > --- > .../drm/i915/gt/selftest_engine_heartbeat.c | 13 +++++---- > drivers/gpu/drm/i915/gt/selftest_llc.c | 29 ++++++++++++------- > 2 files changed, 26 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c > b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c > index b893a8fde895..d26441ee837b 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c > +++ b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c > @@ -195,6 +195,7 @@ static int live_idle_pulse(void *arg) > > static int __live_heartbeat_off(struct intel_engine_cs *engine) > { > + struct drm_i915_private *i915 = engine->i915; > int err; > > intel_engine_pm_get(engine); > @@ -202,8 +203,8 @@ static int __live_heartbeat_off(struct intel_engine_cs > *engine) > engine->serial++; > flush_delayed_work(&engine->heartbeat.work); > if (!delayed_work_pending(&engine->heartbeat.work)) { > - pr_err("%s: heartbeat not running\n", > - engine->name); > + drm_err(&i915->drm, "%s: heartbeat not running\n", > + engine->name); > err = -EINVAL; > goto err_pm; > } > @@ -215,15 +216,15 @@ static int __live_heartbeat_off(struct intel_engine_cs > *engine) > engine->serial++; > flush_delayed_work(&engine->heartbeat.work); > if (delayed_work_pending(&engine->heartbeat.work)) { > - pr_err("%s: heartbeat still running\n", > - engine->name); > + drm_err(&i915->drm, "%s: heartbeat still running\n", > + engine->name); > err = -EINVAL; > goto err_beat; > } > > if (READ_ONCE(engine->heartbeat.systole)) { > - pr_err("%s: heartbeat still allocated\n", > - engine->name); > + drm_err(&i915->drm, "%s: heartbeat still allocated\n", > + engine->name); > err = -EINVAL; > goto err_beat; > } > diff --git a/drivers/gpu/drm/i915/gt/selftest_llc.c > b/drivers/gpu/drm/i915/gt/selftest_llc.c > index 779fadcec7c4..17a86e876f9f 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_llc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_llc.c > @@ -6,6 +6,8 @@ > #include "selftest_llc.h" > #include "intel_rps.h" > > +#include <drm/drm_print.h> > +
Include nit, rest looks okay to me Thanks Krzysztof
