Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing `select REGMAP_MMIO` in Kconfig, leading to potential build/link errors. --
commit 391d2ca299019c57f8ca3f0d4ee7e80cac19c1eb Author: Michal Wilczynski <[email protected]> Subject: soc: starfive: Add jh7110-hdmi-subsystem driver This commit adds a parent driver for the monolithic StarFive JH7110 HDMI IP block. It maps the shared register space and creates separate logical child devices for the HDMI PHY and controller to break a circular probing dependency. > diff --git a/drivers/soc/starfive/Kconfig b/drivers/soc/starfive/Kconfig > new file mode 100644 > index 0000000000000..7592d87dea37a > --- /dev/null > +++ b/drivers/soc/starfive/Kconfig > @@ -0,0 +1,27 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Starfive SoC drivers > +# > + > +if ARCH_STARFIVE || COMPILE_TEST > +menu "Starfive SoC drivers" > + > +config SOC_STARFIVE_JH7110_HDMI_SUBSYSTEM > + tristate "StarFive JH7110 HDMI subsystem driver" > + depends on OF [Severity: Low] Does this Kconfig entry need to select REGMAP_MMIO? If the kernel is configured with SOC_STARFIVE_JH7110_HDMI_SUBSYSTEM=y (for example, during a random COMPILE_TEST build) but without any other driver that enables REGMAP_MMIO, the build will likely fail with a linker error. [ ... ] > diff --git a/drivers/soc/starfive/jh7110-hdmi-subsystem.c > b/drivers/soc/starfive/jh7110-hdmi-subsystem.c > new file mode 100644 > index 0000000000000..d893c1c29f98b > --- /dev/null > +++ b/drivers/soc/starfive/jh7110-hdmi-subsystem.c [ ... ] > + regs = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(regs)) > + return PTR_ERR(regs); > + > + regmap = devm_regmap_init_mmio(dev, regs, > + &starfive_hdmi_regmap_config); [Severity: Low] Could the missing REGMAP_MMIO Kconfig selection cause an undefined reference to __devm_regmap_init_mmio_clk() here during link time? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8
