On Mon, Aug 31, 2026 at 4:51 AM Jani Nikula <[email protected]> wrote:
>
> On Fri, 28 Aug 2026, Thadeu Lima de Souza Cascardo <[email protected]>
> wrote:
> > This reverts commit 321448df7fc9af29b4c6697dc74e6c5e2100af6c.
> >
> > It has broken vkms testing, which has only Virtual connectors.
> >
> > Cc: Mark Yacoub <[email protected]>
> > Cc: Jani Nikula <[email protected]>
> > Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]>
>
> FWIW,
>
> Acked-by: Jani Nikula <[email protected]>
Reviewed-by: Mark Yacoub <[email protected]>
>
> But you should solicit feedback from the author, reviewer, and committer
> of 321448df7fc9 ("lib/igt_kms: Do not treat writeback and virtual
> connectors as connected").
>
>
> > ---
> > lib/igt_kms.h | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> > index 695f666bacb9..27f8877a9f6a 100644
> > --- a/lib/igt_kms.h
> > +++ b/lib/igt_kms.h
> > @@ -669,10 +669,6 @@ static inline bool
> > igt_output_is_connected(igt_output_t *output)
> > !output->config.connector->count_modes)
> > return false;
> >
> > - if (output->config.connector->connector_type ==
> > DRM_MODE_CONNECTOR_WRITEBACK ||
> > - output->config.connector->connector_type ==
> > DRM_MODE_CONNECTOR_VIRTUAL)
> > - return false;
> > -
> > if (output->config.connector->connection == DRM_MODE_CONNECTED)
> > return true;
> >
> >
> > ---
> > base-commit: c0c86b23b316bec7d22bbb95e433a8dc25884a1c
> > change-id: 20260828-vkms_virtual_output_fix-c82298792438
> >
> > Best regards,
> > --
> > Thadeu Lima de Souza Cascardo <[email protected]>
> >
>
> --
> Jani Nikula, Intel
