Re: [PATCH v3 06/40] drm/hisilicon/kirin: Convert to atomic_create_state

[John Stultz]

On Mon, Aug 31, 2026 at 9:18 AM Maxime Ripard <mrip...@kernel.org> wrote:
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c 
> b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index 5f4e738bc94e..bca839dd600b 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -835,11 +835,11 @@ static const struct drm_plane_helper_funcs 
> ade_plane_helper_funcs = {
>
>  static struct drm_plane_funcs ade_plane_funcs = {
>         .update_plane   = drm_atomic_helper_update_plane,
>         .disable_plane  = drm_atomic_helper_disable_plane,
>         .destroy = drm_plane_cleanup,
> -       .reset = drm_atomic_helper_plane_reset,
> +       .atomic_create_state = drm_atomic_helper_plane_create_state,
>         .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
>         .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
>  };
>
>  static void *ade_hw_ctx_alloc(struct platform_device *pdev,

I no longer have hardware to test with, but this looks ok to me.

Acked-by: John Stultz <jstu...@google.com>

thanks
-john