Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Orphaned kernel-doc parameter documentation for @ticket in drm_gem_lru_scan() --
commit 318d69710561d35ea8d576756a021027b6ce9703 Author: Rob Clark <[email protected]> drm/gem: Drop ticket arg to lru_scan() Commit 3392291fc509 ("drm/msm: Fix shrinker deadlock") dropped the only use of the ticket arg, but at the time left drm_gem_lru_scan() unchanged to avoid conflicts with in-flight pathor shrinker support. This commit is the followup to remove the unused arg. > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index 018df97d590dc..5d724da019124 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -1655,8 +1655,7 @@ drm_gem_lru_scan(struct drm_device *dev, > struct drm_gem_lru *lru, > unsigned int nr_to_scan, > unsigned long *remaining, > - bool (*shrink)(struct drm_gem_object *obj, struct > ww_acquire_ctx *ticket), > - struct ww_acquire_ctx *ticket) > + bool (*shrink)(struct drm_gem_object *obj)) > { [Severity: Low] Does this code introduce a documentation regression? The ticket parameter is removed from the drm_gem_lru_scan() function signature here, but it looks like the @ticket description is left behind in the kernel-doc comment block right above this function. This can cause a kernel-doc warning during documentation builds. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
