On Tue Sep 1, 2026 at 8:52 PM JST, Gary Guo wrote: > On Tue Sep 1, 2026 at 6:06 AM BST, Eliot Courtney wrote: >> The new `cv!` macro allows safe casting of constant expressions in a >> const context. Update code in nova-core to use it. >> >> Signed-off-by: Eliot Courtney <[email protected]> > > I like the ergnomics improvement :) > > Reviewed-by: Gary Guo <[email protected]> > >> --- >> drivers/gpu/nova-core/falcon.rs | 9 ++-- >> drivers/gpu/nova-core/fb/hal/gb100.rs | 4 +- >> drivers/gpu/nova-core/firmware/fwsec/bootloader.rs | 7 +-- >> drivers/gpu/nova-core/fsp.rs | 3 +- >> drivers/gpu/nova-core/gsp/cmdq.rs | 6 +-- >> drivers/gpu/nova-core/gsp/fw.rs | 38 +++++++-------- >> drivers/gpu/nova-core/gsp/fw/commands.rs | 2 +- >> drivers/gpu/nova-core/num.rs | 55 >> +--------------------- >> 8 files changed, 28 insertions(+), 96 deletions(-)
Thanks for the reviews!
