Am Montag, 24. August 2026, 12:21:19 Mitteleuropäische Sommerzeit schrieb Johan Jonker via B4 Relay: > From: Hüseyin BIYIK <[email protected]> > > The function devm_drm_bridge_alloc() is the new API for allocating DRM > bridges. > This conversion was missed during the initial conversion of all bridges to > the new API. > > Signed-off-by: Hüseyin BIYIK <[email protected]> > Signed-off-by: Johan Jonker <[email protected]> > --- > drivers/gpu/drm/rockchip/rk3066_hdmi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > index f28d6a883e09..39c65ee07caa 100644 > --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -703,7 +703,6 @@ rk3066_hdmi_register(struct drm_device *drm, struct > rk3066_hdmi *hdmi) > DRM_MODE_ENCODER_TMDS, NULL); > > hdmi->bridge.driver_private = hdmi; > - hdmi->bridge.funcs = &rk3066_hdmi_bridge_funcs; > hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT | > DRM_BRIDGE_OP_EDID | > DRM_BRIDGE_OP_HDMI | > @@ -747,9 +746,10 @@ static int rk3066_hdmi_bind(struct device *dev, struct > device *master, > int irq; > int ret; > > - hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL); > - if (!hdmi) > - return -ENOMEM; > + hdmi = devm_drm_bridge_alloc(dev, struct rk3066_hdmi, bridge, > + &rk3066_hdmi_bridge_funcs); > + if (IS_ERR(hdmi)) > + return PTR_ERR(hdmi);
If I'm reading things correctly, the parts in rk3066_hdmi_register setting hdmi->bridge.driver_private (should use the container field of struct drm_bridge instead) and hdmi->bridge.funcs are redundant by this change? Heiko > > hdmi->dev = dev; > hdmi->drm_dev = drm; > > --- > base-commit: 2709dd5ae32f0828f386327c76bba9f39f63a1c6 > change-id: 20260824-drm-e4689f65ab8c > > Best regards, >
