Thank you for your contribution! Sashiko AI review found 1 potential issue(s) 
to consider:
- [Low] Incorrect grammar correction altering comment meaning.
--

commit a1ccb2e6474d515b1b000ccef6e3cfcb3d32f358
Author: Hemanth Selam <[email protected]>

drm: fix repeated words in comments

This commit addresses warnings from checkpatch.pl by dropping words that appear
to be accidentally repeated in comments. The changes are intended to only touch
comments without affecting code execution.

> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c 
> b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 6dfb45592d747..be3c3c074e75d 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
[ ... ]
> @@ -339,7 +339,7 @@ static int vmw_execbuf_res_val_add(struct vmw_sw_context 
> *sw_context,
>  }
>  
>  /**
> - * vmw_view_res_val_add - Add a view and the surface it's pointing to to the
> + * vmw_view_res_val_add - Add a view and the surface it's pointing to the
>   * validation list
>   *

[Severity: Low]
Does this grammar correction alter the intended meaning of the comment?

The original phrase in vmw_view_res_val_add() uses the first "to" as part of
"pointing to", and the second "to" as part of "to the validation list".
By removing one, the sentence now implies the surface is pointing to the
validation list, rather than adding the surface to the validation list.

>   * @sw_context: The software context holding the validation list.
[ ... ]
> @@ -367,7 +367,7 @@ static int vmw_view_res_val_add(struct vmw_sw_context 
> *sw_context,
>  
>  /**
>   * vmw_view_id_val_add - Look up a view and add it and the surface it's 
> pointing
> - * to to the validation list.
> + * to the validation list.
>   *
>   * @sw_context: The software context holding the validation list.

[Severity: Low]
Does this change have the same issue as above?

It changes the sentence structure in vmw_view_id_val_add() such that it no
longer means adding the surface (that the view points to) to the validation
list.

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=2

Reply via email to