Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete feature removal: the patch deletes the core MFD_RC5T583 driver and header, but leaves behind the GPIO driver and its Kconfig/Makefile entries. --
commit 311a4001bd9ad092f34b02c5b27077bd1e8dfc62 Author: Arnd Bergmann <[email protected]> mfd: remove unused rc5t583 driver The commit removes the Ricoh RC5T583 MFD, regulator, and RTC drivers along with their header file due to the lack of platform data and devicetree support. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 2cb2efafa8a48..fbcc45d2b0c40 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1291,20 +1291,6 @@ config MFD_RT5120 > is targeted at providing the CPU voltage, memory, I/O and peripheral > power rails in home entertainment devices. > > -config MFD_RC5T583 > - bool "Ricoh RC5T583 Power Management system device" > - depends on I2C=y > - select MFD_CORE > - select REGMAP_I2C > - help > - Select this option to get support for the RICOH583 Power > - Management system device. [Severity: Low] Does this removal break Kconfig consistency and leave dead code in the tree? The config GPIO_RC5T583 in drivers/gpio/Kconfig still depends on MFD_RC5T583, which violates Kconfig rules since the target dependency is now missing. Additionally, drivers/gpio/gpio-rc5t583.c is left in the tree and still includes the deleted <linux/mfd/rc5t583.h> header, making it unbuildable, and its entry is still present in drivers/gpio/Makefile. Should the GPIO driver be removed in this patch as well? > - This driver provides common support for accessing the device > - through i2c interface. The device supports multiple sub-devices > - like GPIO, interrupts, RTC, LDO and DCDC regulators, onkey. > - Additional drivers must be enabled in order to use the > - different functionality of the device. > - > config MFD_RK8XX > tristate > select MFD_CORE -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=10
