Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete cleanup: orphaned Makefile entry for `rtc-lp8788.o`. --
commit b9b327cd8a968733772283e939af3a5d5a3cf637 Author: Arnd Bergmann <[email protected]> mfd: remove unused lp8788 driver This commit removes the unused lp8788 driver and its sub-device drivers across multiple subsystems. The driver lacks devicetree support and has apparently never been used upstream. > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index ad5c9b8ceb242..0ce7c1a8f4517 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig [ ... ] > @@ -317,12 +317,6 @@ config RTC_DRV_HYM8563 > This driver can also be built as a module. If so, the module > will be called rtc-hym8563. > > -config RTC_DRV_LP8788 > - tristate "TI LP8788 RTC driver" > - depends on MFD_LP8788 > - help > - Say Y to enable support for the LP8788 RTC/ALARM driver. > - [Severity: Low] This patch removes the CONFIG_RTC_DRV_LP8788 symbol here, and also deletes the drivers/rtc/rtc-lp8788.c source file. Should the corresponding build rule in drivers/rtc/Makefile also be removed? Currently, drivers/rtc/Makefile still contains this entry: obj-$(CONFIG_RTC_DRV_LP8788) += rtc-lp8788.o Since the Kconfig symbol is no longer defined, it evaluates to an empty string, leaving a dead configuration line in the build system. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
