Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Low] Removing `include/linux/mfd/menelaus.h` breaks the build for `arch/arm/mach-omap2/` because the OMAP24xx platform and N8x0 board files were not actually removed from the kernel. - [Low] Selection of a non-existent Kconfig symbol (`MENELAUS`). - [Low] Dangling file reference in the MAINTAINERS file and orphaned defconfig entry. --
commit a734289fbadac21de1944b368a0a47eb10c6d46e Author: Arnd Bergmann <[email protected]> mfd: remove unused menelaus driver Menelaus was a companion chip for the omap24xx platform, which has been remvoed from the kernel, so now the menelaus driver is unused and can be removed. > Menelaus was a companion chip for the omap24xx platform, which has > been remvoed from the kernel, so now the menelaus driver is unused > and can be removed. [Severity: Low] Is the omap24xx platform completely removed? It looks like arch/arm/mach-omap2/board-n8x0.c and arch/arm/mach-omap2/common-board-devices.h still exist and unconditionally include the deleted header, which breaks the build for OMAP2 configurations: arch/arm/mach-omap2/board-n8x0.c: #include <linux/mfd/menelaus.h> arch/arm/mach-omap2/common-board-devices.h: #include <linux/mfd/menelaus.h> extern struct menelaus_platform_data n8x0_menelaus_platform_data; This isn't a bug, but there's a typo (remvoed) in the commit message. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 0395af7270f9e..02e52398fcd28 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -1893,16 +1893,6 @@ config TWL6040_CORE > additional drivers must be enabled in order to use the > functionality of the device (audio, vibra). > > -config MENELAUS > - bool "TI TWL92330/Menelaus PM chip" [Severity: Low] Does removing this config break Kconfig dependencies? arch/arm/mach-omap2/Kconfig still selects this for ARCH_OMAP2PLUS_TYPICAL: arch/arm/mach-omap2/Kconfig:config ARCH_OMAP2PLUS_TYPICAL select MENELAUS if ARCH_OMAP2 Selecting a non-existent symbol triggers a Kconfig warning. [ ... ] > diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c > deleted file mode 100644 > index a125d40fa121b..0000000000000 > --- a/drivers/mfd/menelaus.c > +++ /dev/null > @@ -1,1251 +0,0 @@ [Severity: Low] Should the reference to this file in MAINTAINERS also be removed? MAINTAINERS: F: drivers/mfd/menelaus.c [ ... ] > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index ec73533703f72..9dfe1ea08c250 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -570,15 +570,6 @@ config RTC_DRV_BQ32K > This driver can also be built as a module. If so, the module > will be called rtc-bq32k. > > -config RTC_DRV_TWL92330 > - bool "TI TWL92330/Menelaus" [Severity: Low] Does this leave an orphaned defconfig entry? arch/arm/configs/omap2plus_defconfig still references the removed config: arch/arm/configs/omap2plus_defconfig: CONFIG_RTC_DRV_TWL92330=y -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=13
