Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly added compatible string `img,img-axm-8-256` is omitted from the `power-domains` conditional block, allowing incomplete device tree nodes to silently pass validation. --
commit 2124d2433f8e144a72392a5dd4a2382c06e9682a Author: Geert Uytterhoeven <[email protected]> dt-bindings: gpu: img,powervr-rogue: Document R-Car V4H and V4M support The Renesas R-Car V4H SoC integrates an Imagination Technologies IMG AXM-8-256 GPU, while R-Car V4M integrates an Imagination Technologies IMG BXS-4-64 GPU. Both variants can generate 8 interrupts. > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > index e9218e0f363d1..9bea037602c13 100644 > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -35,6 +35,11 @@ properties: > # work with newer dts. > - const: img,img-axe > - const: img,img-rogue > + - items: > + - enum: > + - renesas,r8a779g0-gpu > + - const: img,img-axm-8-256 > + - const: img,img-rogue [Severity: Medium] Does the newly added img,img-axm-8-256 compatible string need to be included in the power-domains conditional block? Looking at the allOf/power-domains constraints further down in Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml, the existing block requires two power domains for similar hardware: - if: properties: compatible: contains: enum: - img,img-bxs-4-64 - img,img-ge7800 - img,img-gx6250 then: properties: power-domains: minItems: 2 power-domain-names: minItems: 2 required: - power-domains - power-domain-names If a developer compiles a device tree using renesas,r8a779g0-gpu without providing the required two power domains, will the dtbs_check tool process the device tree without flagging the omission? Should this enum list be updated to include img,img-axm-8-256 to correctly enforce the two power domains requirement for the R-Car V4H hardware? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
