Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Unchecked return value from drm_plane_create_blend_mode_property() may silently violate alpha format requirements and cause DRM core warnings. --
commit d27ea97d91c1dff2b3f030af5cf9f066321653e6 Author: Icenowy Zheng <[email protected]> drm/verisilicon: set blend mode for the cursor plane This commit adds a fixed COVERAGE blend mode property to the cursor plane. This is required because blend mode properties must be exposed for pixel formats with alpha. > diff --git a/drivers/gpu/drm/verisilicon/vs_cursor_plane.c > b/drivers/gpu/drm/verisilicon/vs_cursor_plane.c > index fa4f601dd0c87..da456dced88aa 100644 > --- a/drivers/gpu/drm/verisilicon/vs_cursor_plane.c > +++ b/drivers/gpu/drm/verisilicon/vs_cursor_plane.c [ ... ] > @@ -267,6 +268,7 @@ struct drm_plane *vs_cursor_plane_init(struct drm_device > *drm_dev, > return plane; > > drm_plane_helper_add(plane, &vs_cursor_plane_helper_funcs); > + drm_plane_create_blend_mode_property(plane, > BIT(DRM_MODE_BLEND_COVERAGE)); [Severity: Low] Should the return value of drm_plane_create_blend_mode_property() be checked here? If drm_plane_create_blend_mode_property() fails (for example, due to an ENOMEM in drm_property_create()), the cursor plane is initialized without the intended blend mode property. Does this leave the plane in an incomplete state where the DRM core will emit a warning during validation, since the pixel format exposes alpha but the blend mode is not fully set up? > > return plane; > } -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
