Hi Greg, Thanks for the review! > > That's not really needed in a changelog text, it could be in the 0/X > patch :) > Sorry for the clutter. I will move most of them into the 0/X patch in v2.
> Anyway, you didn't cc: the io_uring list, why? > `scripts/get_maintainer.pl` didn't output the io_uring mailing list, likely because this patch doesn't directly touch the io_uring codebase itself. It only enables remapping GPU memory buffers to CPU virtual addresses, which can then be consumed via standard io_uring APIs. I've added [email protected] to CC for this reply and will keep it in v2. > > Nor why "fgds" is the name, that's going to be hard to remember, does it > stand for something? > "FGDS" stands for Fast GPUDirect Storage. GPUDirect Storage (GDS) is NVIDIA's technology enabling direct I/O between GPU memory and files on NVMe, widely used in LLM workloads to bypass CPU overhead. If "FGDS" feels unintuitive, please let us know if you have a better alternative. We will address the rest of the code comments in the v2 patch series soon. Thanks, Li Wang
