Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Incomplete schema validation due to missing compatible string in conditional blocks --
commit f7216936b411ed638371618630b9bc9b852888e7 Author: Mahadevan P <[email protected]> dt-bindings: display/msm: dp-controller: Document Nord DP This commit adds the compatible string for the DisplayPort controller found on the Qualcomm Nord SoC to the device tree bindings. > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 094a6383bb779..8d980acb1a163 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -19,6 +19,7 @@ properties: > oneOf: > - enum: > - qcom,glymur-dp > + - qcom,nord-dp [Severity: Medium] Will this omission cause incomplete schema validation? When qcom,nord-dp is declared here in properties:compatible, it falls back to the weak top-level minimal constraints because it is entirely omitted from the validation logic in the allOf section. The allOf block further down the file defines the conditional logic that strictly validates the register and clock layouts. Shouldn't qcom,nord-dp be categorized into one of these hardware capability blocks to enforce correct constraints during dt_binding_check? Without it, incorrect device tree configurations like incorrect register or clock counts could silently pass validation. > - qcom,sa8775p-dp > - qcom,sc7180-dp > - qcom,sc7280-dp -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
