Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Undocumented Side-Effects / Missing Commit Message Information --
commit b2938fc599ccd3f200169a9387303de5b8f42abe Author: Muzaffer Kadir <[email protected]> dt-bindings: arm: qcom: Document MSM8952 SoC binding This commit documents the MSM8952 SoC binding and adds the General Mobile shamrock to the list of compatible devices. > dt-bindings: arm: qcom: Document MSM8952 SoC binding > > Document the MSM8952 and add General Mobile shamrock to it. [Severity: Medium] Does this commit message accurately reflect the changes in the patch? The commit message explicitly claims only to document the MSM8952 and add General Mobile shamrock to it. However, the patch introduces a 3500-line clock controller driver and multiple unrelated dt-bindings (clock, mmc, nvmem, power). For example, the patch introduces the following probe function: drivers/clk/qcom/gcc-msm8952.c:gcc_msm8952_probe() It appears that this driver is not removed or re-split in subsequent patches in the series. Could the commit message be updated to reflect the full contents, or should this patch be split to separate the clock driver and unrelated dt-bindings for proper subsystem review? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260912-msm8952-initial-support-v1-0-0e742578b...@mainlining.org?part=7
