On Fri, Sep 11, 2026 at 05:04:05PM +0200, Petr Pavlu wrote:
> Several drivers/gpu/drm/xe/*.c files use ALLOW_ERROR_INJECTION(), which is
> defined in asm-generic/error-injection.h. They currently rely on this
> header being included indirectly through linux/module.h ->
> linux/error-injection.h.
>
> Add the missing includes in preparation for removing the
> linux/error-injection.h include from linux/module.h.
>
> Remove also the linux/fault-injection.h include, which commit 91b2c42c214f
> ("drm/xe: Use fault injection infrastructure to find issues at probe time")
> mistakenly used to provide the definition of ALLOW_ERROR_INJECTION().
>
> Signed-off-by: Petr Pavlu <[email protected]>
Reviewed-by: Francois Dugast <[email protected]>
> ---
> drivers/gpu/drm/xe/xe_device.c | 2 +-
> drivers/gpu/drm/xe/xe_exec_queue.c | 1 +
> drivers/gpu/drm/xe/xe_ggtt.c | 2 +-
> drivers/gpu/drm/xe/xe_guc.c | 1 +
> drivers/gpu/drm/xe/xe_guc_ads.c | 2 +-
> drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
> drivers/gpu/drm/xe/xe_guc_log.c | 2 +-
> drivers/gpu/drm/xe/xe_guc_relay.c | 2 +-
> drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c | 1 +
> drivers/gpu/drm/xe/xe_hw_engine_group.c | 2 ++
> drivers/gpu/drm/xe/xe_mmio.c | 1 +
> drivers/gpu/drm/xe/xe_oa.c | 1 +
> drivers/gpu/drm/xe/xe_pm.c | 2 +-
> drivers/gpu/drm/xe/xe_pt.c | 2 ++
> drivers/gpu/drm/xe/xe_pxp.c | 2 ++
> drivers/gpu/drm/xe/xe_sriov.c | 2 +-
> drivers/gpu/drm/xe/xe_sync.c | 1 +
> drivers/gpu/drm/xe/xe_tile.c | 2 +-
> drivers/gpu/drm/xe/xe_tuning.c | 2 ++
> drivers/gpu/drm/xe/xe_uc_fw.c | 2 +-
> drivers/gpu/drm/xe/xe_vm.c | 1 +
> drivers/gpu/drm/xe/xe_wa.c | 2 +-
> drivers/gpu/drm/xe/xe_wopcm.c | 2 +-
> 23 files changed, 27 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index ee732e5495f7..fcef8d5fc7ca 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -7,7 +7,7 @@
>
> #include <linux/aperture.h>
> #include <linux/delay.h>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
> #include <linux/units.h>
>
> #include <drm/drm_client.h>
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c
> b/drivers/gpu/drm/xe/xe_exec_queue.c
> index cd053de3c6b5..3e46c14584c4 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -5,6 +5,7 @@
>
> #include "xe_exec_queue.h"
>
> +#include <linux/error-injection.h>
> #include <linux/nospec.h>
>
> #include <drm/drm_device.h>
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 8ec23862477f..e05582ad098a 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -6,7 +6,7 @@
> #include "xe_ggtt.h"
>
> #include <kunit/visibility.h>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
> #include <linux/io-64-nonatomic-lo-hi.h>
> #include <linux/sizes.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index 4286bd05c686..34e21a70d5ad 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -5,6 +5,7 @@
>
> #include "xe_guc.h"
>
> +#include <linux/error-injection.h>
> #include <linux/iopoll.h>
> #include <drm/drm_managed.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_ads.c b/drivers/gpu/drm/xe/xe_guc_ads.c
> index ff8eee3831aa..41a2b8c807d6 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ads.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ads.c
> @@ -5,7 +5,7 @@
>
> #include "xe_guc_ads.h"
>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include <drm/drm_managed.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index fe70c0fd85c5..ac6cbbaa6cc0 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -8,7 +8,7 @@
> #include <linux/bitfield.h>
> #include <linux/circ_buf.h>
> #include <linux/delay.h>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include <kunit/static_stub.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
> index 538d4df0f7aa..6f0739204d9e 100644
> --- a/drivers/gpu/drm/xe/xe_guc_log.c
> +++ b/drivers/gpu/drm/xe/xe_guc_log.c
> @@ -5,7 +5,7 @@
>
> #include "xe_guc_log.h"
>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include <linux/utsname.h>
> #include <drm/drm_managed.h>
> diff --git a/drivers/gpu/drm/xe/xe_guc_relay.c
> b/drivers/gpu/drm/xe/xe_guc_relay.c
> index eed0a750d2eb..e528d95ba7fe 100644
> --- a/drivers/gpu/drm/xe/xe_guc_relay.c
> +++ b/drivers/gpu/drm/xe/xe_guc_relay.c
> @@ -5,7 +5,7 @@
>
> #include <linux/bitfield.h>
> #include <linux/delay.h>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include <drm/drm_managed.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
> b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
> index d42e263e0611..ac81f382e7dc 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c
> @@ -4,6 +4,7 @@
> */
>
> #include <drm/drm_managed.h>
> +#include <linux/error-injection.h>
> #include <linux/kobject.h>
> #include <linux/sysfs.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_group.c
> b/drivers/gpu/drm/xe/xe_hw_engine_group.c
> index 0804b426b6f9..418ff427ae30 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_group.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_group.c
> @@ -3,6 +3,8 @@
> * Copyright © 2024 Intel Corporation
> */
>
> +#include <linux/error-injection.h>
> +
> #include <drm/drm_managed.h>
>
> #include "xe_assert.h"
> diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
> index 7fa18dfcb5a2..d8f8a2453bb6 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.c
> +++ b/drivers/gpu/drm/xe/xe_mmio.c
> @@ -6,6 +6,7 @@
> #include "xe_mmio.h"
>
> #include <linux/delay.h>
> +#include <linux/error-injection.h>
> #include <linux/io-64-nonatomic-lo-hi.h>
> #include <linux/minmax.h>
> #include <linux/pci.h>
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index ab09dcff5860..b15c96e35fab 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -5,6 +5,7 @@
>
> #include <linux/anon_inodes.h>
> #include <linux/delay.h>
> +#include <linux/error-injection.h>
> #include <linux/nospec.h>
> #include <linux/poll.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index a5289a9df8d2..c0489a8d8a62 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -5,7 +5,7 @@
>
> #include "xe_pm.h"
>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
> #include <linux/pm_runtime.h>
> #include <linux/suspend.h>
> #include <linux/dmi.h>
> diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
> index a07316a45d79..6c6d9be2717e 100644
> --- a/drivers/gpu/drm/xe/xe_pt.c
> +++ b/drivers/gpu/drm/xe/xe_pt.c
> @@ -5,6 +5,8 @@
>
> #include "xe_pt.h"
>
> +#include <linux/error-injection.h>
> +
> #include "regs/xe_gtt_defs.h"
> #include "xe_bo.h"
> #include "xe_device.h"
> diff --git a/drivers/gpu/drm/xe/xe_pxp.c b/drivers/gpu/drm/xe/xe_pxp.c
> index 2fef274a585e..2f3632ac201a 100644
> --- a/drivers/gpu/drm/xe/xe_pxp.c
> +++ b/drivers/gpu/drm/xe/xe_pxp.c
> @@ -5,6 +5,8 @@
>
> #include "xe_pxp.h"
>
> +#include <linux/error-injection.h>
> +
> #include <drm/drm_managed.h>
> #include <uapi/drm/xe_drm.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_sriov.c b/drivers/gpu/drm/xe/xe_sriov.c
> index f3835867fce5..ec254b950daf 100644
> --- a/drivers/gpu/drm/xe/xe_sriov.c
> +++ b/drivers/gpu/drm/xe/xe_sriov.c
> @@ -3,7 +3,7 @@
> * Copyright © 2023 Intel Corporation
> */
>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include <drm/drm_managed.h>
>
> diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
> index 37866768d64c..711de22f4986 100644
> --- a/drivers/gpu/drm/xe/xe_sync.c
> +++ b/drivers/gpu/drm/xe/xe_sync.c
> @@ -6,6 +6,7 @@
> #include "xe_sync.h"
>
> #include <linux/dma-fence-array.h>
> +#include <linux/error-injection.h>
> #include <linux/kthread.h>
> #include <linux/sched/mm.h>
> #include <linux/uaccess.h>
> diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
> index 74d925a337b7..810dfd98d830 100644
> --- a/drivers/gpu/drm/xe/xe_tile.c
> +++ b/drivers/gpu/drm/xe/xe_tile.c
> @@ -3,7 +3,7 @@
> * Copyright © 2023 Intel Corporation
> */
>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include <drm/drm_managed.h>
> #include <drm/drm_pagemap_util.h>
> diff --git a/drivers/gpu/drm/xe/xe_tuning.c b/drivers/gpu/drm/xe/xe_tuning.c
> index bcec40ca2d35..d3d38b4380be 100644
> --- a/drivers/gpu/drm/xe/xe_tuning.c
> +++ b/drivers/gpu/drm/xe/xe_tuning.c
> @@ -5,6 +5,8 @@
>
> #include "xe_tuning.h"
>
> +#include <linux/error-injection.h>
> +
> #include <kunit/visibility.h>
>
> #include <drm/drm_managed.h>
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index a8e6f18cc9b4..f17925ad53f5 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -4,7 +4,7 @@
> */
>
> #include <linux/bitfield.h>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
> #include <linux/firmware.h>
>
> #include <drm/drm_managed.h>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 23952ad8951e..f000564f1e59 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -6,6 +6,7 @@
> #include "xe_vm.h"
>
> #include <linux/dma-fence-array.h>
> +#include <linux/error-injection.h>
> #include <linux/nospec.h>
>
> #include <drm/drm_drv.h>
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index 139434946f8f..98d2fdd3ba6f 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -8,7 +8,7 @@
> #include <drm/drm_managed.h>
> #include <kunit/visibility.h>
> #include <linux/compiler_types.h>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include <generated/xe_device_wa_oob.h>
> #include <generated/xe_wa_oob.h>
> diff --git a/drivers/gpu/drm/xe/xe_wopcm.c b/drivers/gpu/drm/xe/xe_wopcm.c
> index fe65ed246775..7da1e3ebc839 100644
> --- a/drivers/gpu/drm/xe/xe_wopcm.c
> +++ b/drivers/gpu/drm/xe/xe_wopcm.c
> @@ -5,7 +5,7 @@
>
> #include "xe_wopcm.h"
>
> -#include <linux/fault-inject.h>
> +#include <linux/error-injection.h>
>
> #include "regs/xe_guc_regs.h"
> #include "xe_device.h"
>
> --
> 2.55.0
