Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The binding schema omits default values for `solomon,width` and `solomon,height`. --
commit d69921d470fb48f9128b8539591beb3d33f26088 Author: Amit Barzilai <[email protected]> dt-bindings: display: Add Solomon SSD1351 OLED controller This commit adds a device tree binding for the Solomon SSD1351 RGB OLED display controller. It builds upon the shared solomon,ssd-common.yaml properties. > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > new file mode 100644 > index 0000000000000..80850c2ab5b3e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml [ ... ] > +allOf: > + - $ref: solomon,ssd-common.yaml# > + > +properties: > + compatible: > + enum: > + - solomon,ssd1351 [Severity: Low] Does this properties block need to define solomon,width and solomon,height with default constraints? The SSD1351 controller is 128x128 according to the commit message. Since this binding includes solomon,ssd-common.yaml, validation of a device tree node for solomon,ssd1351 without explicit width and height properties will not populate or document the default values in the schema output. Adding these properties here with a default constraint of 128 would match the hardware specs and maintain subsystem consistency. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
