On 9/12/26 10:39 AM, Muzaffer Kadir via B4 Relay wrote:
> From: Muzaffer Kadir <[email protected]>
>
> Add General Mobile Shamrock (GM 5 Plus).
> Shamrock is designed similar to L9300.
> Downstream reference is [1].
Please feel free to
wrap your messages at 72
characters, otherwise they are
a bit hard to read! :D
[...]
> +/ {
> + model = "General Mobile GM 5 Plus (shamrock)";
It's not any "policy", but other DTs tend to only put the "pretty
name" here, without the codename
[...]
> + framebuffer {
> + compatible = "simple-framebuffer";
> + memory-region = <&cont_splash_mem>;
> +
> + width = <1080>;
> + height = <1920>;
> + stride = <(1080 * 3)>;
> + format = "r8g8b8";
> +
> + power-domains = <&gcc MDSS_GDSC>;
> +
> + clocks = <&gcc GCC_MDSS_AHB_CLK>,
> + <&gcc GCC_MDSS_AXI_CLK>,
> + <&gcc GCC_MDSS_VSYNC_CLK>,
> + <&gcc GCC_MDSS_MDP_CLK>,
> + <&gcc GCC_MDSS_BYTE0_CLK>,
> + <&gcc GCC_MDSS_PCLK0_CLK>,
> + <&gcc GCC_MDSS_ESC0_CLK>;
Please align the '<'s, make sure your tab width is set to 8
[...]
> + multi-led {
> + compatible = "leds-group-multicolor";
> + color = <LED_COLOR_ID_RGB>;
> + function = LED_FUNCTION_INDICATOR;
> + leds = <&red_status>, <&green_status>, <&blue_status>;
> + };
> +
> +};
Stray \n above
[...]
> +&ramoops_mem {
> + status = "okay";
> +};
> +
> +&adsp {
> + status = "okay";
> +};
> +
> +&lpass_mem {
> + status = "okay";
> +};
Please sort the label references alphabetically
> +
> +&pm8950_spmi_regulators {
> + // PM8950 S5 + S6 = VDD_APC supply
Let's use /* C-style comments */
[...]
> +&tlmm {
> + gpio-reserved-ranges = <20 4>; // Downstream doesn't use 21,22,23. 24
> is mdss_te
Let's keep a \n between the last property and the following subnode
[...]
> + tpa6130a2_default: tpa6130a2-default-state {
> + pins = "gpio61";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-down;
> + output-low;
Drop this property, the driver will take care of it
Konrad
