Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:
Critical: 0 · High: 0 · Medium: 1 · Low: 0
- [Medium] In Documentation/devicetree/bindings/net/cortina,gemini-
ethernet.yaml the patch does more than re-indent: it deletes the whole…
--
dt-bindings: net: Use consistent indentation in the example
This reindents the DT binding examples under Documentation/devicetree/
bindings/net/ to consistent 2- or 4-space indentation so that
dt-check-style stops reporting "indent mismatch" warnings. Twelve
binding files are touched.
> diff --git
> a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> index f0b5bea2458d5..da9bc170cd543 100644
> --- a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> @@ -87,18 +87,6 @@ examples:
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/cortina,gemini-clock.h>
> #include <dt-bindings/reset/cortina,gemini-reset.h>
> - mdio0: mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - phy0: ethernet-phy@1 {
> - reg = <1>;
> - device_type = "ethernet-phy";
> - };
> - phy1: ethernet-phy@3 {
> - reg = <3>;
> - device_type = "ethernet-phy";
> - };
> - };
[Severity: Medium]
Is this deletion intended? The commit message says only:
Correct indentation in the examples to consistent 2- or 4-spaces
indentation to fix dt-check-style warnings
Every other hunk in the series is a pure whitespace shift with the brace
nesting preserved, but here the whole mdio0 node with phy0 and phy1 is
removed and nothing is added back.
Wouldn't re-indenting the mdio0 node to 4 spaces achieve the stated goal
without dropping the example content?
>
> ethernet@60000000 {
> compatible = "cortina,gemini-ethernet";
> @@ -110,28 +98,28 @@ examples:
> ranges;
>
> gmac0: ethernet-port@0 {
[ ... ]
> + phy-mode = "rgmii";
> + phy-handle = <&phy0>;
> };
[Severity: Medium]
Do the surviving phy-handle properties in gmac0 and gmac1 now reference
labels that no longer exist in the file? After this patch the file
contains:
gmac0: ethernet-port@0 {
...
phy-handle = <&phy0>;
};
gmac1: ethernet-port@1 {
...
phy-handle = <&phy1>;
};
but there is no longer any definition of phy0 or phy1 anywhere in
cortina,gemini-ethernet.yaml, and the example no longer shows the MDIO bus
and PHY topology it used to illustrate.
If the mdio0 removal is deliberate, could it go into a separate patch that
also updates the phy-handle references?
>
> gmac1: ethernet-port@1 {
[ ... ]
> + phy-mode = "rgmii";
> + phy-handle = <&phy1>;
> };
> };
[ ... remaining files snipped, no comments ... ]
--
Sashiko AI review ·
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260913122910.99457-3-krzysztof.kozlowski%40oss.qualcomm.com
