On 13.09.2026 09:31, [email protected] wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s)
to consider:
- [Low] Direct use of `usleep_range` instead of `mipi_dsi_usleep_range`
bypasses multi-context error tracking.
--
commit 883b76cff93d823c9430acc0b7cfca0a77f61ed2
Author: Alexey Minnekhanov <[email protected]>
drm/panel: novatek-nt36672a: Add Tianma panel for Xiaomi Mi A2
Add support for Tianma TL060FVXS16-00 video mode panel based on
Novatek NT36672A, used in Xiaomi Mi A2 smartphone (xiaomi-jasmine).
It shares some code with already supported panel in this driver
for xiaomi-lavender, so we can reuse the same panel deinit function.
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
index e6971ba6ef464..1bfa808365874 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
@@ -445,6 +445,29 @@ static void lavender_tulip_deinit_cmds(struct
mipi_dsi_multi_context *dsi_ctx)
mipi_dsi_msleep(dsi_ctx, 120);
}
+static void tianma_jasmine_init_cmds(struct mipi_dsi_multi_context *dsi_ctx)
+{
[ ... ]
+ mipi_dsi_dcs_set_display_on_multi(dsi_ctx);
+ usleep_range(5000, 6000);
[Severity: Low]
Is it intentional to use usleep_range() here instead of mipi_dsi_usleep_range()?
Using usleep_range() directly bypasses the multi-context error tracking in
tianma_jasmine_init_cmds(). This causes the unconditional 5-6ms sleep to
execute even if previous DSI commands have failed and set dsi_ctx->accum_err.
+}
Good find, this is likely not intentional, will be fixed in v2.
--
Regards,
Alexey Minnekhanov
