Re: [PATCH v3 18/19] riscv: dts: starfive: jh7110: Update DT for display subsystem

[Michal Wilczynski]

On 9/10/26 10:37, Krzysztof Kozlowski wrote:
> On Fri, Sep 04, 2026 at 03:27:19PM +0200, Michal Wilczynski wrote:
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi 
>> b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> index 
>> 9c3e4598747eb5541effe697044484715569a285..0f981f4c89586269b987be8591037c9461e04703
>>  100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> @@ -290,12 +290,6 @@ gmac1_rmii_refin: gmac1-rmii-refin-clock {
>>              #clock-cells = <0>;
>>      };
>>  
>> -    hdmitx0_pixelclk: hdmitx0-pixel-clock {
>> -            compatible = "fixed-clock";
>> -            clock-output-names = "hdmitx0_pixelclk";
>> -            #clock-cells = <0>;
>> -    };
>> -
>>      i2srx_bclk_ext: i2srx-bclk-ext-clock {
>>              compatible = "fixed-clock";
>>              clock-output-names = "i2srx_bclk_ext";
>> @@ -352,6 +346,13 @@ tdm_ext: tdm-ext-clock {
>>              #clock-cells = <0>;
>>      };
>>  
>> +    xin24m: xin24m {
> 
> Other clocks are called foo-clock, so follow this as well (even though
> it does not follow recommended practice of clock-foo, but at least some
> consistency).

will rename to to xin24m-clock

> 
> Best regards,
> Krzysztof
> 
> 

Best regards,
-- 
Michal Wilczynski <m.wilczyn...@samsung.com>