Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] nouveau/gsp: r535_gsp_get_static_memsys_info omitted from R535 init path --
commit 66ae2756f54f0408a696a11be12bc7b083f1942f Author: Lyude Paul <[email protected]> drm/nouveau/gsp/r535: Add support for MEMSYS_GET_STATIC_CONFIG This patch introduces a GSP structure describing memory management system characteristics. It adds code to fetch this structure during driver load and saves the use_raw_mode_comptagline_alloc flag for later use. > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c > index 09b17b85dc1ac..5df5365e744f5 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c [ ... ] > @@ -1808,6 +1808,23 @@ r535_gsp_fini(struct nvkm_gsp *gsp, enum > nvkm_suspend_state suspend) > return 0; > } > > +int > +r535_gsp_get_static_memsys_info(struct nvkm_gsp *gsp) > +{ > + NV2080_CTRL_INTERNAL_MEMSYS_GET_STATIC_CONFIG_PARAMS *ctrl; > + > + ctrl = nvkm_gsp_rm_ctrl_rd(&gsp->internal.device.subdevice, > + > NV2080_CTRL_CMD_INTERNAL_MEMSYS_GET_STATIC_CONFIG, > + sizeof(*ctrl)); > + if (IS_ERR(ctrl)) > + return PTR_ERR(ctrl); > + > + gsp->memsys.use_raw_mode_comptagline_alloc = > ctrl->bUseRawModeComptaglineAllocation; > + > + nvkm_gsp_rm_ctrl_done(&gsp->internal.device.subdevice, ctrl); > + return 0; > +} > + [Severity: Medium] Should r535_gsp_get_static_info() in this file also call this function? The commit message indicates this adds support for R535, but it looks like this function is only called from r570_gsp_get_static_info() in r570/gsp.c. Because it is omitted from r535_gsp_get_static_info(), gsp->memsys remains uninitialized on R535 hardware. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
