> -----Original Message----- > From: Bill Wendling <[email protected]> > Sent: Tuesday, September 15, 2026 10:19 AM > To: [email protected] > Cc: Bill Wendling <[email protected]>; Russell King > <[email protected]>; Huacai Chen <[email protected]>; WANG > Xuerui <[email protected]>; Thomas Bogendoerfer > <[email protected]>; James E.J. Bottomley > <[email protected]>; Helge Deller <[email protected]>; > Thomas Gleixner <[email protected]>; Ingo Molnar <[email protected]>; > Borislav Petkov <[email protected]>; Dave Hansen > <[email protected]>; [email protected]; H. Peter Anvin > <[email protected]>; Ian Abbott <[email protected]>; H Hartley Sweeten > <[email protected]>; Luck, Tony <[email protected]>; > Maarten Lankhorst <[email protected]>; Maxime Ripard > <[email protected]>; Thomas Zimmermann <[email protected]>; David > Airlie <[email protected]>; Simona Vetter <[email protected]>; Brost, > Matthew <[email protected]>; Thomas Hellström > <[email protected]>; Vivi, Rodrigo > <[email protected]>; Dmitry Torokhov <[email protected]>; > Matthias Schwarzott <[email protected]>; Mauro Carvalho Chehab > <[email protected]>; Nguyen, Anthony L <[email protected]>; > Kitszel, Przemyslaw <[email protected]>; Andrew Lunn > <[email protected]>; David S. Miller <[email protected]>; Eric > Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo > Abeni <[email protected]>; Arend van Spriel > <[email protected]>; Rob Herring <[email protected]>; > Saravana Kannan <[email protected]>; Krzysztof Kozlowski > <[email protected]>; Sylwester Nawrocki <[email protected]>; Peter > Griffin <[email protected]>; Alim Akhtar > <[email protected]>; Linus Walleij <[email protected]>; Anil > Gurumurthy <[email protected]>; Sudarsana Kalluru > <[email protected]>; Martin K. Petersen <[email protected]>; > Trond Myklebust <[email protected]>; Anna Schumaker > <[email protected]>; Mike Marshall <[email protected]>; Martin > Brandenburg <[email protected]>; Kees Cook <[email protected]>; Jiri > Pirko <[email protected]>; Simon Horman <[email protected]>; Chuck Lever > <[email protected]>; Jeff Layton <[email protected]>; NeilBrown > <[email protected]>; Olga Kornievskaia <[email protected]>; Dai Ngo > <[email protected]>; Tom Talpey <[email protected]>; Jaroslav Kysela > <[email protected]>; Takashi Iwai <[email protected]>; Andrew Morton > <[email protected]>; Mike Rapoport (Microsoft) > <[email protected]>; Kanglong Wang <[email protected]>; Tiezhu > Yang <[email protected]>; Qiang Ma <[email protected]>; > Randy Dunlap <[email protected]>; Pengpeng Hou > <[email protected]>; Ard Biesheuvel <[email protected]>; Breno Leitao > <[email protected]>; Thorsten Blum <[email protected]>; Harshit > Mogalapalli <[email protected]>; Greg Kroah-Hartman > <[email protected]>; Lyude Paul <[email protected]>; Ashutosh > Desai <[email protected]>; Deak, Imre <[email protected]>; > Dmitry Baryshkov <[email protected]>; Johan Hovold > <[email protected]>; Berg, Johannes <[email protected]>; > Korenblit, Miriam Rachel <[email protected]>; > Alexander Stein <[email protected]>; Cryolitia PukNgae > <[email protected]>; Jiaming Zhang <[email protected]>; Will > Porter <[email protected]>; Cen Zhang <[email protected]>; > Cássio Gabriel <[email protected]>; Rong Zhang > <[email protected]>; Arun Raghavan <[email protected]>; linux-arm- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; intel- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected] > Subject: [PATCH 24/28] EDAC/thunderx: Fix stale error context in > thunderx_l2c_threaded_isr() > > thunderx_l2c_threaded_isr() computes "tail" and "ctx" once before > entering the loop that drains the L2C error ring, and never updates > them on subsequent iterations. When multiple errors are queued, every > iteration reports the first ring entry rather than advancing through > the ring, causing subsequent hardware errors in a batch to go > unreported. > > Recompute "tail" and "ctx" at the start of each loop iteration, > matching the sibling thunderx_ocx_com_threaded_isr() and > thunderx_ocx_lnk_threaded_isr() handlers. > > Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC > driver") > Signed-off-by: Bill Wendling <[email protected]> > --- > Cc: Russell King <[email protected]> > Cc: Huacai Chen <[email protected]> > Cc: WANG Xuerui <[email protected]> > Cc: Thomas Bogendoerfer <[email protected]> > Cc: "James E.J. Bottomley" <[email protected]> > Cc: Helge Deller <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: Dave Hansen <[email protected]> > Cc: [email protected] > Cc: "H. Peter Anvin" <[email protected]> > Cc: Ian Abbott <[email protected]> > Cc: H Hartley Sweeten <[email protected]> > Cc: Tony Luck <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: Maxime Ripard <[email protected]> > Cc: Thomas Zimmermann <[email protected]> > Cc: David Airlie <[email protected]> > Cc: Simona Vetter <[email protected]> > Cc: Matthew Brost <[email protected]> > Cc: "Thomas Hellström" <[email protected]> > Cc: Rodrigo Vivi <[email protected]> > Cc: Dmitry Torokhov <[email protected]> > Cc: Matthias Schwarzott <[email protected]> > Cc: Mauro Carvalho Chehab <[email protected]> > Cc: Tony Nguyen <[email protected]> > Cc: Przemek Kitszel <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Eric Dumazet <[email protected]> > Cc: Jakub Kicinski <[email protected]> > Cc: Paolo Abeni <[email protected]> > Cc: Arend van Spriel <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Saravana Kannan <[email protected]> > Cc: Krzysztof Kozlowski <[email protected]> > Cc: Sylwester Nawrocki <[email protected]> > Cc: Peter Griffin <[email protected]> > Cc: Alim Akhtar <[email protected]> > Cc: Linus Walleij <[email protected]> > Cc: Anil Gurumurthy <[email protected]> > Cc: Sudarsana Kalluru <[email protected]> > Cc: "Martin K. Petersen" <[email protected]> > Cc: Trond Myklebust <[email protected]> > Cc: Anna Schumaker <[email protected]> > Cc: Mike Marshall <[email protected]> > Cc: Martin Brandenburg <[email protected]> > Cc: Kees Cook <[email protected]> > Cc: Jiri Pirko <[email protected]> > Cc: Simon Horman <[email protected]> > Cc: Chuck Lever <[email protected]> > Cc: Jeff Layton <[email protected]> > Cc: NeilBrown <[email protected]> > Cc: Olga Kornievskaia <[email protected]> > Cc: Dai Ngo <[email protected]> > Cc: Tom Talpey <[email protected]> > Cc: Jaroslav Kysela <[email protected]> > Cc: Takashi Iwai <[email protected]> > Cc: Bill Wendling <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: "Mike Rapoport (Microsoft)" <[email protected]> > Cc: Kanglong Wang <[email protected]> > Cc: Tiezhu Yang <[email protected]> > Cc: Qiang Ma <[email protected]> > Cc: Randy Dunlap <[email protected]> > Cc: Pengpeng Hou <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Breno Leitao <[email protected]> > Cc: Thorsten Blum <[email protected]> > Cc: Harshit Mogalapalli <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Lyude Paul <[email protected]> > Cc: Ashutosh Desai <[email protected]> > Cc: Imre Deak <[email protected]> > Cc: Dmitry Baryshkov <[email protected]> > Cc: Johan Hovold <[email protected]> > Cc: Johannes Berg <[email protected]> > Cc: Miri Korenblit <[email protected]> > Cc: Alexander Stein <[email protected]> > Cc: Cryolitia PukNgae <[email protected]> > Cc: Jiaming Zhang <[email protected]> > Cc: Will Porter <[email protected]> > Cc: Cen Zhang <[email protected]> > Cc: "Cássio Gabriel" <[email protected]> > Cc: Rong Zhang <[email protected]> > Cc: Arun Raghavan <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > drivers/edac/thunderx_edac.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/edac/thunderx_edac.c > b/drivers/edac/thunderx_edac.c index 9c0a1e48f96f..e7c335ca0c36 100644 > --- a/drivers/edac/thunderx_edac.c > +++ b/drivers/edac/thunderx_edac.c > @@ -1880,6 +1880,9 @@ static irqreturn_t thunderx_l2c_threaded_isr(int > irq, void *irq_id) > > while (CIRC_CNT(l2c->ring_head, l2c->ring_tail, > ARRAY_SIZE(l2c->err_ctx))) { > + tail = ring_pos(l2c->ring_tail, ARRAY_SIZE(l2c- > >err_ctx)); > + ctx = &l2c->err_ctx[tail]; > + > snprintf(msg, L2C_MESSAGE_SIZE, > "%s: %s: %016llx, %s: %016llx", > l2c->edac_dev->ctl_name, reg_int_name, ctx- > >reg_int, > -- > 2.55.0.1032.g73a4cd73de-goog
Reviewed-by: Aleksandr Loktionov <[email protected]>
