On Sat, 2026-08-15 at 11:30 -0600, Jim Cromie wrote: > When hardware or firmware initialization fails, the graphics engine > (gr) or device functions may remain NULL. Attempting to access these > during the GETPARAM ioctl (e.g., NOUVEAU_GETPARAM_GRAPH_UNITS) > results > in a kernel NULL pointer dereference, causing a crash when userspace > (GNOME/Mesa) attempts to probe the device. > > Add safety checks for 'gr', 'gr->func', and 'nvkm_device->func' in > the > ioctl handler. Return -ENODEV to signal the missing hardware state to > userspace, and use NV_ERROR_ONCE to provide diagnostic proof in the > kernel log without risking a console flood. > > RFC: > > These crashes may not be repeatable, they happened while I was trying > to build nouveau as a builtin module, with binary blobs in the kernel > image, on a laptop with an encrypted disk. Gemini tells me this > won't > work, so I punted.
"Gemini tells me this won't work, so I punted." I'm sorry, what exactly do you mean here? And could you clarify what LLMs were used for in writing this series? Code generation, analysis, etc.? > > Signed-off-by: Jim Cromie <[email protected]>
