From: David Heidelberg <[email protected]>

Due to incorrect implementation 0 == asserted, thus when driver fails it
needs to assert reset.

Minimal fix for stable; the polarity convention is corrected properly
later in this series.

Fixes: 779679d3c1640 ("drm/panel: Add support for S6E3HA8 panel driver")
Cc: [email protected]
Assisted-by: LLM
Signed-off-by: David Heidelberg <[email protected]>
---
 drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c 
b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
index 078523df48860..835121b322f4a 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
@@ -179,17 +179,17 @@ static int s6e3ha8_amb577px01_wqhd_prepare(struct 
drm_panel *panel)
        ret = regulator_bulk_enable(ARRAY_SIZE(s6e3ha8_supplies), 
priv->supplies);
        if (ret < 0)
                return ret;
        mipi_dsi_msleep(&ctx, 120);
        s6e3ha8_amb577px01_wqhd_reset(priv);
 
        ret = s6e3ha8_amb577px01_wqhd_on(priv);
        if (ret < 0) {
-               gpiod_set_value_cansleep(priv->reset_gpio, 1);
+               gpiod_set_value_cansleep(priv->reset_gpio, 0);
                goto err;
        }
 
        drm_dsc_pps_payload_pack(&pps, &priv->dsc);
 
        samsung_dsi_test_key_on_lvl1(&ctx);
        mipi_dsi_picture_parameter_set_multi(&ctx, &pps);
        samsung_dsi_test_key_off_lvl1(&ctx);

-- 
2.55.0


Reply via email to