Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dma-buf: build failure in dma-buf-mapping.c due to missing pci-p2pdma include --
commit 8de2b0ebefc837cd0e3d5d4be72922d840602ba3 Author: Christian König <[email protected]> dma-buf: remove pci-p2pdma include from dma-buf.h v2 This commit removes the <linux/pci-p2pdma.h> include from <linux/dma-buf.h> to eliminate an unwanted dependency on the PCI subsystem. It uses a forward declaration in <linux/dma-buf-mapping.h> instead. > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index d15b2b31d3c91..159271fcf3d2e 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -22,7 +22,6 @@ > #include <linux/fs.h> > #include <linux/dma-fence.h> > #include <linux/wait.h> > -#include <linux/pci-p2pdma.h> [Severity: Low] Does removing this include break the build for drivers/dma-buf/dma-buf-mapping.c? That file unconditionally uses functions and enum values from the pci-p2pdma header without explicitly including it, relying on this transitive inclusion. For example: drivers/dma-buf/dma-buf-mapping.c:dma_buf_phys_vec_to_sgt() { ... switch (pci_p2pdma_map_type(provider, attach->dev)) { case PCI_P2PDMA_MAP_BUS_ADDR: ... } Will this lead to a compile-time failure for drivers/dma-buf/dma-buf-mapping.c due to undeclared identifiers? > > struct device; > struct dma_buf; -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
