Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/bridge: missing newline character in dev_err() format strings --
commit 66842dcef6ab0efdd620d9bb8ab7b4ec82630515 Author: Daniel Golle <[email protected]> drm/bridge: it6505: complete poweroff even if disabling regulators fails This commit modifies the bridge poweroff sequence to continue disabling the hardware even if regulator disablement fails. It logs the failure instead of returning early to avoid wedging the bridge. > diff --git a/drivers/gpu/drm/bridge/ite-it6505.c > b/drivers/gpu/drm/bridge/ite-it6505.c > index 19bab8d65e222..b9e5ce36f556a 100644 > --- a/drivers/gpu/drm/bridge/ite-it6505.c > +++ b/drivers/gpu/drm/bridge/ite-it6505.c > @@ -2814,13 +2814,15 @@ static int it6505_poweroff(struct it6505 *it6505) > if (pdata->pwr18) { > err = regulator_disable(pdata->pwr18); > if (err) > - return err; > + dev_err(dev, "cannot disable pwr18 regulator: %d", > + err); [Severity: Low] Is this error log format string missing a newline character? Without a \n, the kernel log buffer may not immediately flush the message, or subsequent messages might be incorrectly appended to this line, leading to garbled logs. > } > > if (pdata->ovdd) { > err = regulator_disable(pdata->ovdd); > if (err) > - return err; > + dev_err(dev, "cannot disable ovdd regulator: %d", > + err); [Severity: Low] Similarly, should this error log format string also include a trailing \n? > } > > it6505->powered = false; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=5
