> > Original compatible describing only the DDIC used, but omit describing > the panel used (Samsung AMB577PX01), which we have no way to detect. > > New compatible allows without breaking ABI fixing the inverted reset. > > Assisted-by: LLM > Signed-off-by: David Heidelberg <[email protected]> > --- > arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > index bd59f1dcd96dc..c156ed3733b4e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts > @@ -262,23 +262,23 @@ &mdss { > status = "okay"; > }; > > &mdss_dsi0 { > vdda-supply = <&vreg_l26a_1p2>; > status = "okay"; > > panel@0 { > - compatible = "samsung,s6e3ha8"; > + compatible = "samsung,s6e3ha8-amb577px01";
I guess that keeping the original "samsung,s6e3ha8" would cause that ABI break ABI, right? compatible = "samsung,s6e3ha8-amb577px01", "samsung,s6e3ha8"; Anyway, LGTM. Reviewed-by: Petr Vorel <[email protected]> Kind regards, Petr > reg = <0>; > vci-supply = <&s2dos05_ldo4>; > vddr-supply = <&s2dos05_buck>; > vdd3-supply = <&s2dos05_ldo1>; > te-gpios = <&tlmm 10 GPIO_ACTIVE_HIGH>; > - reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; > pinctrl-0 = <&dsi_default &dsi_te>; > pinctrl-1 = <&dsi_suspend &dsi_te>; > pinctrl-names = "default", "suspend"; > > port { > panel_in: endpoint { > remote-endpoint = <&mdss_dsi0_out>; > }; >
