Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] kbuild: link error when GEM helpers are built-in and DRM_CLIENT_LIB is modular --
commit d69668549441f21758d69fc518df18536eb9bb24 Author: Thomas Zimmermann <[email protected]> Subject: drm/fbdev: Move fbdev helpers into client library This commit moves DRM's fbdev emulation helpers into the client library module and renames them from drm_fb_helper to drm_fbdev_helper. > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig [ ... ] > @@ -256,7 +255,6 @@ config DRM_TTM_HELPER > tristate > depends on DRM > select DRM_TTM > - select DRM_KMS_HELPER if DRM_FBDEV_EMULATION > select FB_CORE if DRM_FBDEV_EMULATION > select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > help [Severity: Low] When DRM_KMS_HELPER is removed here, is there a replacement needed for the client library? If a built-in driver selects DRM_TTM_HELPER=y and DRM_FBDEV_EMULATION=y, but a modular driver forces DRM_CLIENT_LIB=m, can this result in a vmlinux link error because the fbdev emulation code in the client library is not built-in? > @@ -265,7 +263,6 @@ config DRM_TTM_HELPER > config DRM_GEM_DMA_HELPER > tristate > depends on DRM > - select DRM_KMS_HELPER if DRM_FBDEV_EMULATION > select FB_CORE if DRM_FBDEV_EMULATION > select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > help [Severity: Low] Does this missing replacement for the client library dependency also leave config DRM_GEM_DMA_HELPER susceptible to the same link error when built-in? > @@ -274,7 +271,6 @@ config DRM_GEM_DMA_HELPER > config DRM_GEM_SHMEM_HELPER > tristate > depends on DRM && MMU > - select DRM_KMS_HELPER if DRM_FBDEV_EMULATION > select FB_CORE if DRM_FBDEV_EMULATION > select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > help [Severity: Low] Similarly, should config DRM_GEM_SHMEM_HELPER select the client library to prevent a link error when DRM_FBDEV_EMULATION is enabled? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
