Re: [PATCH] drm/amdgpu: remove unused adev parameter from amdgpu_vm_pt_free_list

[Tvrtko Ursulin]

On 25/09/2026 09:54, Thadeu Lima de Souza Cascardo wrote:
Since commit b6c4f90b3819 ("drm/amdgpu: sync page table freeing with tlb
flush") simplified amdgpu_vm_pt_free_dfs into amdgpu_vm_pt_free_list, it
does not need adev as it already finds the target PTs on the
tlb_flush_waitlist.

It also looks like accessing adev from the params is idiomatic in this 
code so:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursu...@igalia.com>

Regards,

Tvrtko

Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@igalia.com>
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c    | 2 +-
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h    | 3 +--
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 4 +---
  3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index bb04101b0fb5..d090bbbdc00d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1252,7 +1252,7 @@ int amdgpu_vm_update_range(struct amdgpu_device *adev, 
struct amdgpu_vm *vm,
                tlb_cb = NULL;
        }
  
-	amdgpu_vm_pt_free_list(adev, &params);
+       amdgpu_vm_pt_free_list(&params);
  
  error_free:
        kfree(tlb_cb);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
index d32183cd9e0f..5d9063e71268 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
@@ -613,8 +613,7 @@ int amdgpu_vm_ptes_update(struct amdgpu_vm_update_params 
*params,
                          uint64_t start, uint64_t end,
                          uint64_t dst, uint64_t flags);
  void amdgpu_vm_pt_free_work(struct work_struct *work);
-void amdgpu_vm_pt_free_list(struct amdgpu_device *adev,
-                           struct amdgpu_vm_update_params *params);
+void amdgpu_vm_pt_free_list(struct amdgpu_vm_update_params *params);
  
  #if defined(CONFIG_DEBUG_FS)
  void amdgpu_debugfs_vm_bo_info(struct amdgpu_vm *vm, struct seq_file *m);
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
index e43a60d09808..af0d95fa8965 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
@@ -551,13 +551,11 @@ static void amdgpu_vm_pt_free(struct amdgpu_vm_bo_base 
*entry)
  /**
   * amdgpu_vm_pt_free_list - free PD/PT levels
   *
- * @adev: amdgpu device structure
   * @params: see amdgpu_vm_update_params definition
   *
   * Free the page directory objects saved in the flush list
   */
-void amdgpu_vm_pt_free_list(struct amdgpu_device *adev,
-                           struct amdgpu_vm_update_params *params)
+void amdgpu_vm_pt_free_list(struct amdgpu_vm_update_params *params)
  {
        struct amdgpu_vm_bo_base *entry, *next;
        bool unlocked = params->unlocked;

---
base-commit: 62f4c998b297cf233997a2b4cd6fc2d2df0319c9
change-id: 20260924-amdgpu_vm_pt_free_list_args-1eed6131aab5

Best regards,
--
Thadeu Lima de Souza Cascardo <casca...@igalia.com>