On Thu, 24 Sep 2026, Krzysztof Karas <[email protected]> wrote: > Move away from generic pr prints to drm device context aware > i915_* versions.
So I think moving away from pr_* to drm_* logging is fine, and there's a limited amount of that. But the i915_* macros just open the door to an insane amount of churn converting drm_* to i915_* everywhere in a driver that's essentially in maintenance mode now, for no real benefit to anyone. BR, Jani. > > Assisted-by: GitHub-Copilot:claude-opus-5 > Assisted-by: GitHub-Copilot:claude-sonnet-5 > Signed-off-by: Krzysztof Karas <[email protected]> > --- > v4: > - renamed from "Use drm_* prints in selftest headers" (the title > did not match the change) and switched to the new i915_* > prints instead of drm_*; > > drivers/gpu/drm/i915/selftests/i915_selftest.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c > b/drivers/gpu/drm/i915/selftests/i915_selftest.c > index 3adcfdab75ae..4e2566189879 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_selftest.c > +++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c > @@ -23,6 +23,8 @@ > > #include <linux/random.h> > > +#include "i915_printk.h" > + > #include "gt/intel_gt.h" > #include "gt/intel_gt_pm.h" > #include "gt/intel_gt_regs.h" > @@ -47,7 +49,7 @@ int i915_mock_sanitycheck(void) > > int i915_live_sanitycheck(struct drm_i915_private *i915) > { > - pr_info("%s: %s() - ok!\n", i915->drm.driver->name, __func__); > + i915_info(i915, "%s() - ok!\n", __func__); > return 0; > } > > @@ -154,7 +156,7 @@ __wait_gsc_proxy_completed(struct drm_i915_private *i915) > > if (need_to_wait && > wait_for(!__gsc_proxy_init_progressing(&i915->media_gt->uc.gsc), > timeout_ms)) > - pr_warn(DRIVER_NAME "Timed out waiting for > gsc_proxy_completion!\n"); > + i915_warn(i915, "Timed out waiting for > gsc_proxy_completion!\n"); > } > > static void > @@ -178,7 +180,7 @@ __wait_gsc_huc_load_completed(struct drm_i915_private > *i915) > > if (need_to_wait && > wait_for(i915_sw_fence_done(&huc->delayed_load.fence), timeout_ms)) > - pr_warn(DRIVER_NAME "Timed out waiting for huc load via > GSC!\n"); > + i915_warn(i915, "Timed out waiting for huc load via GSC!\n"); > } > > static struct mm_struct *get_selftest_mm(int u_pid_nr) -- Jani Nikula, Intel
