Add DRM plane properties for the clear_on_* and refresh_mode_init
session management flags, allowing userspace to control automatic
display clear/refresh behaviour at lifecycle transitions:
- clear_on_init: clear display when a new DRM master opens
- clear_on_close: clear display when the displaying client exits
- clear_on_disable: clear display when CRTC is disabled
- refresh_mode_init: override refresh mode for the first frame
after a new master opens (e.g. force full refresh to clear
ghosting before normal partial updates)
Each property is an enum with values:
disabled / partial / full / fast
These map to the internal representation (-1 for disabled, 0/1/2 for
partial/full/fast refresh modes respectively).
Defaults are seeded from the panel configuration at probe time and
can be adjusted at runtime via standard DRM property interfaces
(e.g. modetest, drm_info, or compositor property APIs).
Signed-off-by: Devarsh Thakkar <[email protected]>
---
Changes from v1:
- New patch: Extracted session management properties into dedicated patch
as plane properties
drivers/gpu/drm/solomon/ssd16xx.c | 134 ++++++++++++++++++++++++++++++
1 file changed, 134 insertions(+)
diff --git a/drivers/gpu/drm/solomon/ssd16xx.c
b/drivers/gpu/drm/solomon/ssd16xx.c
index 3815af0cee5c..6331f367d864 100644
--- a/drivers/gpu/drm/solomon/ssd16xx.c
+++ b/drivers/gpu/drm/solomon/ssd16xx.c
@@ -205,6 +205,18 @@ enum ssd16xx_color_mode {
SSD16XX_COLOR_MODE_3COLOR = 1, /* 3-colour BWR; RED RAM used for red
pixels */
};
+/*
+ * Clear/refresh-mode-init session property values exposed to userspace.
+ * "disabled" means the action is skipped; the others select which refresh
+ * mode to use for the clear/init operation.
+ */
+enum ssd16xx_session_mode {
+ SSD16XX_SESSION_DISABLED = 0,
+ SSD16XX_SESSION_PARTIAL,
+ SSD16XX_SESSION_FULL,
+ SSD16XX_SESSION_FAST,
+};
+
/* Border waveform enum indices (0-9); mapped to HW bytes via
* controller_cfg->border_waveform_table[]
*/
@@ -402,6 +414,10 @@ struct ssd16xx_device {
struct drm_framebuffer *last_fb; /* Last drawn FB for reinit
redraws */
struct drm_property *refresh_mode_property;
struct drm_property *color_mode_property;
+ struct drm_property *clear_on_init_property;
+ struct drm_property *clear_on_close_property;
+ struct drm_property *clear_on_disable_property;
+ struct drm_property *refresh_mode_init_property;
};
/* Plane state subclass: refresh_mode lives on the plane, not the connector,
@@ -411,6 +427,10 @@ struct ssd16xx_plane_state {
struct drm_shadow_plane_state base;
enum ssd16xx_refresh_mode refresh_mode; /* Pending refresh mode */
enum ssd16xx_color_mode color_mode; /* Pending color mode */
+ int clear_on_init; /* Session: -1=disabled, 0=partial, 1=full,
2=fast */
+ int clear_on_close;
+ int clear_on_disable;
+ int refresh_mode_init;
};
#define to_ssd16xx_plane_state(s) \
@@ -1426,6 +1446,10 @@ static struct drm_plane_state
*ssd16xx_plane_atomic_create_state(struct drm_plan
__drm_gem_shadow_plane_state_init(plane, &ssd_state->base);
ssd_state->refresh_mode = device->refresh_mode;
ssd_state->color_mode = device->color_mode;
+ ssd_state->clear_on_init = device->clear_on_init;
+ ssd_state->clear_on_close = device->clear_on_close;
+ ssd_state->clear_on_disable = device->clear_on_disable;
+ ssd_state->refresh_mode_init = device->refresh_mode_init;
return &ssd_state->base.base;
}
@@ -1456,6 +1480,24 @@ static void ssd16xx_plane_atomic_destroy_state(struct
drm_plane *plane,
kfree(ssd_state);
}
+/*
+ * Convert internal clear_on / refresh_mode_init value (-1=disabled,
0/1/2=mode)
+ * to the userspace-facing enum (0=disabled, 1=partial, 2=full, 3=fast).
+ */
+static inline unsigned int ssd16xx_internal_to_session_prop(int internal_val)
+{
+ if (internal_val < 0)
+ return SSD16XX_SESSION_DISABLED;
+ return (unsigned int)internal_val + 1;
+}
+
+static inline int ssd16xx_session_prop_to_internal(uint64_t prop_val)
+{
+ if (prop_val == SSD16XX_SESSION_DISABLED)
+ return -1;
+ return (int)prop_val - 1;
+}
+
static int ssd16xx_plane_atomic_get_property(struct drm_plane *plane,
const struct drm_plane_state
*state,
struct drm_property *property,
@@ -1472,6 +1514,22 @@ static int ssd16xx_plane_atomic_get_property(struct
drm_plane *plane,
*val = ssd_state->color_mode;
return 0;
}
+ if (property == device->clear_on_init_property) {
+ *val =
ssd16xx_internal_to_session_prop(ssd_state->clear_on_init);
+ return 0;
+ }
+ if (property == device->clear_on_close_property) {
+ *val =
ssd16xx_internal_to_session_prop(ssd_state->clear_on_close);
+ return 0;
+ }
+ if (property == device->clear_on_disable_property) {
+ *val =
ssd16xx_internal_to_session_prop(ssd_state->clear_on_disable);
+ return 0;
+ }
+ if (property == device->refresh_mode_init_property) {
+ *val =
ssd16xx_internal_to_session_prop(ssd_state->refresh_mode_init);
+ return 0;
+ }
return -EINVAL;
}
@@ -1501,6 +1559,30 @@ static int ssd16xx_plane_atomic_set_property(struct
drm_plane *plane,
ssd_state->color_mode = val;
return 0;
}
+ if (property == device->clear_on_init_property) {
+ if (val > SSD16XX_SESSION_FAST)
+ return -EINVAL;
+ ssd_state->clear_on_init =
ssd16xx_session_prop_to_internal(val);
+ return 0;
+ }
+ if (property == device->clear_on_close_property) {
+ if (val > SSD16XX_SESSION_FAST)
+ return -EINVAL;
+ ssd_state->clear_on_close =
ssd16xx_session_prop_to_internal(val);
+ return 0;
+ }
+ if (property == device->clear_on_disable_property) {
+ if (val > SSD16XX_SESSION_FAST)
+ return -EINVAL;
+ ssd_state->clear_on_disable =
ssd16xx_session_prop_to_internal(val);
+ return 0;
+ }
+ if (property == device->refresh_mode_init_property) {
+ if (val > SSD16XX_SESSION_FAST)
+ return -EINVAL;
+ ssd_state->refresh_mode_init =
ssd16xx_session_prop_to_internal(val);
+ return 0;
+ }
return -EINVAL;
}
@@ -1588,6 +1670,10 @@ static void ssd16xx_plane_atomic_update(struct drm_plane
*plane,
device->refresh_mode = new_ssd->refresh_mode;
device->color_mode = new_ssd->color_mode;
+ device->clear_on_init = new_ssd->clear_on_init;
+ device->clear_on_close = new_ssd->clear_on_close;
+ device->clear_on_disable = new_ssd->clear_on_disable;
+ device->refresh_mode_init = new_ssd->refresh_mode_init;
/*
* When refresh_mode_init was set, use the specified mode for this first
@@ -1897,6 +1983,13 @@ static const struct drm_prop_enum_list
ssd16xx_color_mode_enum[] = {
{ SSD16XX_COLOR_MODE_3COLOR, "3-color" },
};
+static const struct drm_prop_enum_list ssd16xx_session_mode_enum[] = {
+ { SSD16XX_SESSION_DISABLED, "disabled" },
+ { SSD16XX_SESSION_PARTIAL, "partial" },
+ { SSD16XX_SESSION_FULL, "full" },
+ { SSD16XX_SESSION_FAST, "fast" },
+};
+
static int ssd16xx_plane_create_properties(struct ssd16xx_device *device)
{
struct drm_device *drm = &device->drm;
@@ -1928,6 +2021,47 @@ static int ssd16xx_plane_create_properties(struct
ssd16xx_device *device)
drm_object_attach_property(plane_obj,
device->color_mode_property,
device->color_mode);
+
+ device->clear_on_init_property =
+ drm_property_create_enum(drm, 0, "clear_on_init",
+ ssd16xx_session_mode_enum,
+ ARRAY_SIZE(ssd16xx_session_mode_enum));
+ if (!device->clear_on_init_property)
+ return -ENOMEM;
+ drm_object_attach_property(plane_obj,
+ device->clear_on_init_property,
+
ssd16xx_internal_to_session_prop(device->clear_on_init));
+
+ device->clear_on_close_property =
+ drm_property_create_enum(drm, 0, "clear_on_close",
+ ssd16xx_session_mode_enum,
+ ARRAY_SIZE(ssd16xx_session_mode_enum));
+ if (!device->clear_on_close_property)
+ return -ENOMEM;
+ drm_object_attach_property(plane_obj,
+ device->clear_on_close_property,
+
ssd16xx_internal_to_session_prop(device->clear_on_close));
+
+ device->clear_on_disable_property =
+ drm_property_create_enum(drm, 0, "clear_on_disable",
+ ssd16xx_session_mode_enum,
+ ARRAY_SIZE(ssd16xx_session_mode_enum));
+ if (!device->clear_on_disable_property)
+ return -ENOMEM;
+ drm_object_attach_property(plane_obj,
+ device->clear_on_disable_property,
+
ssd16xx_internal_to_session_prop(device->clear_on_disable));
+
+ device->refresh_mode_init_property =
+ drm_property_create_enum(drm, 0, "refresh_mode_init",
+ ssd16xx_session_mode_enum,
+ ARRAY_SIZE(ssd16xx_session_mode_enum));
+ if (!device->refresh_mode_init_property)
+ return -ENOMEM;
+ drm_object_attach_property(plane_obj,
+ device->refresh_mode_init_property,
+
ssd16xx_internal_to_session_prop(device->refresh_mode_init));
+
return 0;
}
static const struct drm_connector_funcs ssd16xx_connector_funcs = {
--
2.39.1
