Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] drm/bridge: commit message and tree context mismatch --
commit ac5ab6aba140c1bdb755618fe3998cc33d9cf30b Author: Arnd Bergmann <[email protected]> drm/bridge: add missing drm/drm_panel.h inclusions This commit adds <drm/drm_panel.h> includes to various drm/bridge drivers. The commit message states this is to fix implicit declaration build failures after devm_drm_of_get_bridge() was moved to drm_panel.h. > The devm_drm_of_get_bridge() declaration moved to drm_panel.h, but > not all callers include this, which leads to build failures in > some configurations: > > drivers/gpu/drm/imx/lcdc/imx-lcdc.c: In function 'imx_lcdc_probe': > drivers/gpu/drm/imx/lcdc/imx-lcdc.c:404:18: error: implicit declaration > of function 'devm_drm_of_get_bridge' [-Wimplicit-function-declaration] > 404 | bridge = devm_drm_of_get_bridge(dev, dev->of_node, 0, 0); > | ^~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/verisilicon/vs_bridge.c: In function 'vs_bridge_init': > drivers/gpu/drm/verisilicon/vs_bridge.c:306:16: error: implicit > declaration of function 'devm_drm_of_get_bridge' > [-Wimplicit-function-declaration] > 306 | next = devm_drm_of_get_bridge(drm_dev->dev, > drm_dev->dev->of_node, > | ^~~~~~~~~~~~~~~~~~~~~~ > > Include the new header in all files that need it. > > Fixes: aa8a8c7e4641 ("drm/bridge: panel: move all code to drm_panel.c") [Severity: Medium] Is the premise of this commit accurate for the current tree? Looking at include/drm/drm_bridge.h, devm_drm_of_get_bridge() is still declared there: include/drm/drm_bridge.h: struct drm_bridge *devm_drm_of_get_bridge(struct device *dev, struct device_node *node, u32 port, u32 endpoint); Because the prerequisite commit aa8a8c7e4641 appears to be missing in this tree, the declaration remains in drm_bridge.h and the mentioned build failure does not exist here. Does this patch depend on another series, or is it premature for this particular branch? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
