Hi Miguel, Thank you for the review.
On Mon, Sep 8, 2026 at 9:47 PM Miguel Ojeda <[email protected]> wrote: > > SZ_4G is used by the Tyr driver when splitting the GPU VA range into > user and kernel regions. > > The message should explain what changes, e.g. a new paragraph after > this one like "Thus add a new trait that ... and implement it for > `u64` because ...". Done in v3 -- the commit message now includes the explanation. > +const unsigned long long RUST_CONST_HELPER_SZ_4G = SZ_4G; > > Is it added here to be nearby other sizes, or something else? Yes -- to keep the size-related helpers grouped together. > +/// Only implemented for `u64`. > > Intra-doc link: [`u64`] Addressed. The Acked-by is already carried in the commit. Best regards, Alvin
