devm_drm_of_get_bridge() is deprecated, switch to
of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() returns
a refcounted bridge, ensure it is put by using bridge.next_bridge.

Fixes build failure when CONFIG_OF is disabled.

Fixes: aa8a8c7e4641 ("drm/bridge: panel: move all code to drm_panel.c")
Reported-by: Arnd Bergmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Luca Ceresoli <[email protected]>
---
 drivers/gpu/drm/verisilicon/vs_bridge.c | 7 +++----
 drivers/gpu/drm/verisilicon/vs_bridge.h | 1 -
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.c 
b/drivers/gpu/drm/verisilicon/vs_bridge.c
index dc7c85b07fe3..f1e8112f0ed2 100644
--- a/drivers/gpu/drm/verisilicon/vs_bridge.c
+++ b/drivers/gpu/drm/verisilicon/vs_bridge.c
@@ -29,7 +29,7 @@ static int vs_bridge_attach(struct drm_bridge *bridge,
 {
        struct vs_bridge *vbridge = drm_bridge_to_vs_bridge(bridge);
 
-       return drm_bridge_attach(encoder, vbridge->next_bridge,
+       return drm_bridge_attach(encoder, vbridge->base.next_bridge,
                                 bridge, flags);
 }
 
@@ -303,8 +303,7 @@ struct vs_bridge *vs_bridge_init(struct drm_device *drm_dev,
                return NULL;
        }
 
-       next = devm_drm_of_get_bridge(drm_dev->dev, drm_dev->dev->of_node,
-                                     output, intf);
+       next = of_drm_get_bridge_by_endpoint(drm_dev->dev->of_node, output, 
intf);
        if (IS_ERR(next)) {
                ret = PTR_ERR(next);
                if (ret != -EPROBE_DEFER)
@@ -326,7 +325,7 @@ struct vs_bridge *vs_bridge_init(struct drm_device *drm_dev,
 
        bridge->crtc = crtc;
        bridge->intf = intf;
-       bridge->next_bridge = next;
+       bridge->base.next_bridge = next;
 
        if (intf == VSDC_OUTPUT_INTERFACE_DPI)
                enctype = DRM_MODE_ENCODER_DPI;
diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.h 
b/drivers/gpu/drm/verisilicon/vs_bridge.h
index 70fee1749699..2b0ed94e4520 100644
--- a/drivers/gpu/drm/verisilicon/vs_bridge.h
+++ b/drivers/gpu/drm/verisilicon/vs_bridge.h
@@ -25,7 +25,6 @@ struct vs_bridge {
        struct drm_connector *conn;
 
        struct vs_crtc *crtc;
-       struct drm_bridge *next_bridge;
        enum vs_bridge_output_interface intf;
 };
 

-- 
2.55.0

Reply via email to