Hi, On Tue, Sep 29, 2026 at 1:02 AM Hsieh Hung-En <[email protected]> wrote: > > Replace the deprecated mipi_dsi_dcs_exit_sleep_mode() and > mipi_dsi_dcs_enter_sleep_mode() calls in the enable and disable callbacks > with their _multi variants, as suggested in Documentation/gpu/todo.rst. > > The callbacks retain the same return values. The new helpers additionally > log an error if the command fails. > > Signed-off-by: Hsieh Hung-En <[email protected]> > --- > > Notes: > Compile-tested on arm64 with W=1; not tested on hardware. > > drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-)
_multi doesn't buy us much here, but this is still something we want to do so we can (eventually) remove the old functions. Thus: Reviewed-by: Douglas Anderson <[email protected]> I'll be at a conference next week and will probably wait until I get back before applying, just in case there are problems. So unless someone else applies in the meantime (or other issues come up), I'll try to land in ~2 weeks. > diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > index c3fbc459c..ebe6352db 100644 > --- a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > +++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > @@ -75,15 +75,19 @@ static int rb070d30_panel_unprepare(struct drm_panel > *panel) > static int rb070d30_panel_enable(struct drm_panel *panel) > { > struct rb070d30_panel *ctx = panel_to_rb070d30_panel(panel); > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > - return mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > + return dsi_ctx.accum_err; > } > > static int rb070d30_panel_disable(struct drm_panel *panel) > { > struct rb070d30_panel *ctx = panel_to_rb070d30_panel(panel); > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > - return mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > + return dsi_ctx.accum_err; > } nit: not new for your change, but it's probably better if rb070d30_panel_disable() ignores the error here and always returns 0. We often ignore errors in disable(), especially when unprepare() will power the panel off anyway. If you wanted to send a followup patch fixing that, it would be nice. ;-) -Doug
