Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] amdxdna: missing sysfs string mapping for AIE2_DEV_REVISION_GRGH --
commit b3b57d80604172a34fe04c44b6e2dfb08e2fd5da Author: Lizhi Hou <[email protected]> accel/amdxdna: Add support for AIE2 revision 9 This commit adds AIE2_DEV_REVISION_GRGH to the list of supported AIE2 revisions so aie2_get_dev_revision() can recognize AIE2 revision 9 hardware. > diff --git a/drivers/accel/amdxdna/aie2_msg_priv.h > b/drivers/accel/amdxdna/aie2_msg_priv.h > index fd65a4236d491..8ed2b5701dcc2 100644 > --- a/drivers/accel/amdxdna/aie2_msg_priv.h > +++ b/drivers/accel/amdxdna/aie2_msg_priv.h > @@ -530,6 +530,7 @@ enum aie2_dev_revision { > AIE2_DEV_REVISION_GPT1, > AIE2_DEV_REVISION_GPT2, > AIE2_DEV_REVISION_GPT3, > + AIE2_DEV_REVISION_GRGH, [Severity: Medium] Does AIE2_DEV_REVISION_GRGH also need to be added to the npu4_rev_vbnv_tbl mapping array? drivers/accel/amdxdna/npu4_regs.c:npu4_rev_vbnv_tbl[] { ... { AIE2_DEV_REVISION_GPT2, "NPU Gorgon Point 2" }, { AIE2_DEV_REVISION_GPT3, "NPU Gorgon Point 3" }, { 0 } }; If it is omitted, when the sysfs 'vbnv' node is accessed for GRGH devices, amdxdna_update_vbnv() fails to find a matching entry. This causes the driver to fall back to a generic default string ('RyzenAI-npu4'), exposing an inaccurate or missing specific board name to userspace. > AIE2_DEV_REVISION_UNKN, > }; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
