Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Unused macro MAX_HDMI_TMDS_CHAR_RATE_HZ left as dead code --
commit 4c0965b876d8cee6ad2805996d389a95afff88cf Author: Cristian Ciocaltea <[email protected]> drm/bridge: ite-it6263: Advertise HDMI 1.3 capabilities This commit advertises HDMI 1.3 support for the IT6263 bridge and sets the maximum TMDS character rate. It also removes the now-redundant it6263_hdmi_tmds_char_rate_valid() hook, as the core DRM helper handles these checks before invoking the driver's hook. > diff --git a/drivers/gpu/drm/bridge/ite-it6263.c > b/drivers/gpu/drm/bridge/ite-it6263.c > index 550999491086e..e8e0197171e10 100644 > --- a/drivers/gpu/drm/bridge/ite-it6263.c > +++ b/drivers/gpu/drm/bridge/ite-it6263.c > @@ -738,20 +738,6 @@ it6263_bridge_atomic_get_input_bus_fmts(struct > drm_bridge *bridge, > return input_fmts; > } > > -static enum drm_mode_status > -it6263_hdmi_tmds_char_rate_valid(const struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - unsigned long long tmds_rate) > -{ > - if (mode->clock > MAX_PIXEL_CLOCK_KHZ) > - return MODE_CLOCK_HIGH; > - > - if (tmds_rate > MAX_HDMI_TMDS_CHAR_RATE_HZ) [Severity: Low] With the removal of the it6263_hdmi_tmds_char_rate_valid() hook, the macro MAX_HDMI_TMDS_CHAR_RATE_HZ in drivers/gpu/drm/bridge/ite-it6263.c is no longer referenced anywhere. Should this unused macro also be removed to prevent leaving dead code behind? > - return MODE_CLOCK_HIGH; > - > - return MODE_OK; > -} -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
